Changes between Initial Version and Version 1 of Ticket #13342


Ignore:
Timestamp:
04/14/2010 07:06:52 AM (9 years ago)
Author:
Russell Keith-Magee
Comment:

The proposed behavior strikes me as a fairly major change to the existing behavior, but it isn't clear to me that the existing behaviour is wrong, or that the proposed behavior is more correct.

The report and patch doesn't give any test cases to validate why the proposed change would be correct, so I'm closing wontfix. If you want to argue your case, please bring it up on Django-developers.

Regardless of the decision, the ticket isn't 1.2 critical.

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #13342

    • Property Status changed from new to closed
    • Property Resolution changed from to wontfix
    • Property Milestone changed from 1.2 to
  • Ticket #13342 – Description

    initial v1  
    11MultiValueField is composed from several child fields
    22Validation logic in it's clean method should be:
    3 - if MultiValueField is required, at least one of the child values must be non-empty (ok)
    4 - if a child field is required, it's value must be non-empty (bug in implementation, MultiValueField.required is used instead of child.required to check condition)
    5 - clean decompressed values by each child fields and compress together (ok)
     3 - if MultiValueField is required, at least one of the child values must be non-empty (ok)
     4 - if a child field is required, it's value must be non-empty (bug in implementation, MultiValueField.required is used instead of child.required to check condition)
     5 - clean decompressed values by each child fields and compress together (ok)
Back to Top