Opened 15 years ago
Last modified 8 years ago
#13327 new
FileField/ImageField accessor methods throw unnecessary exceptions when they are blank or null. — at Version 1
Description (last modified by ) ¶
Many of the accessor methods on the FileField call this method:
def _require_file(self): if not self: raise ValueError("The '%s' attribute has no file associated with it." % self.field.name)
This method defeats the blank or null features, and has 0 benefit.
The preferred behavior should be that it raises an error if the field is set, but the file does not exist. However if you try to retrieve a URL or path from a file-field it should return None if the field is Null or if the field is blank. Not sure what the reasoning behind throwing an error here, is but it seems extremely dis-advantageous in practice requiring every image or file-field that can be blank/null to have if/else statement wrapped around it in templates to prevent 500 errors.
According to the ticket's flags, the next step(s) to move this issue forward are:
- To provide a patch by sending a pull request. Claim the ticket when you start working so that someone else doesn't duplicate effort. Before sending a pull request, review your work against the patch review checklist. Check the "Has patch" flag on the ticket after sending a pull request and include a link to the pull request in the ticket comment when making that update. The usual format is:
[https://github.com/django/django/pull/#### PR]
.
Please use preview.