Changes between Initial Version and Version 1 of Ticket #13093
- Timestamp:
- Mar 11, 2010, 7:44:21 PM (14 years ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
Ticket #13093
- Property Triage Stage Unreviewed → Accepted
-
Ticket #13093 – Description
initial v1 1 1 The cache_page() decorator works fine on views, but fails if you use it on a callable class:: 2 class:3 2 {{{ 4 3 class MyView(object): … … 7 6 }}} 8 7 9 If you try to wrap this view in urls.py ({{{ cache_page(MyView(), 60) }}}), you get an error saying "MyView doesn't have attribute __name__". cache_page uses the __name__ attribute to build a cache key, but classes dont have a __name__ attribute. cache_page should also check for __class__.__name__ (or some similar key with a per-instance feature) to allow for wrapping callable classes.8 If you try to wrap this view in urls.py ({{{ cache_page(MyView(), 60) }}}), you get an error saying "MyView doesn't have attribute !__name!__". cache_page uses the !__name!__ attribute to build a cache key, but classes dont have a !__name!__ attribute. cache_page should also check for !__class!__.!__name!__ (or some similar key with a per-instance feature) to allow for wrapping callable classes. 10 9 11 10 This is a problem for 1.2, because feed views have been moved to a class-based structure, so it is no longer possible to cache feed views using cache_page().