Opened 15 years ago

Last modified 12 years ago

#12140 closed

urlencode empty list encoding bug & fix — at Initial Version

Reported by: aneil Owned by: nobody
Component: HTTP handling Version: dev
Severity: Normal Keywords: urlencode
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

django.utils.http.urlencode doesn't behave the same as urllib.urlencode for empty lists:

urllib.urlencode({'foo':[]},True) =>

django.utils.http.urlencode({'foo':[]},True) => 'foo=%5B%5D'

The attached diff has a change at line 557 in trunk/django/utils/http.py:

  • isinstance(v, (list,tuple)) and [smart_str(i) for i in v] or smart_str(v))

+ [smart_str(i) for i in v] if isinstance(v, (list,tuple)) else smart_str(v))

Attached.

Change History (1)

by aneil, 15 years ago

Attachment: urlencode.diff​ added

urlencode empty list bug patch

Note: See TracTickets for help on using tickets.
Back to Top