Add wsgiorg.routing args support

[Gustavo Narea]

The ​wsgiorg.routing_args standard may be really useful if you want to use WSGI middleware or applications inside Django because some of them take advantage of that to do nice/useful things.

It's currently not supported in Django - But it will with the attached patch.

[edit] fixed broken link.

[Gustavo Narea]

I forgot to mention, the patch assumes that the WSGI environment is available, which won't true with mod_python until the patch I sent for #8927 is applied.

[Gustavo Narea]

Improved patch to support wsgiorg.routing_args

[Gustavo Narea]

I reimplemented this functionality as a Django middleware in twod.wsgi. That middleware has full unit test coverage:
​http://bitbucket.org/2degrees/twod.wsgi/src/tip/twod/wsgi/middleware.py
​http://bitbucket.org/2degrees/twod.wsgi/src/tip/tests/test_middleware.py

Would you like me to write a patch with the middleware or write tests for the initial patch?

[Aymeric Augustin]

Change UI/UX from NULL to False.

[Aymeric Augustin]

Change Easy pickings from NULL to False.

[Gustavo Narea]

I've created a pull request for this: ​https://github.com/django/django/pull/1004

I haven't written any documentation, but I'm happy to do it once it's been approved, in case the solution changes radically.

[Anvesh Mishra]

Created a ​PR, a lot documentation still needs to be done and maybe some implementation changes.

[Jacob Walls]

Resetting docs flag for new PR

[Florian Apolloner]

Two things that come to mind:

• On a technical level I think if this were to be in core it should be done via django/core/handlers/wsgi where resolve_request could be overwritten to set request.environ/META directly from the returned resolver_match there (unconditionally, I don't see much gain in a middleware and extra setters/getters for such a niche feature).

• On a organizational level I'd like to ask: Do we need this? If someone wants it, there is always request.resolver_match which can be used to copy this data into environ['wsgiorg.routing_args'] as needed.

Given point two I'd like to ask if there are any popular python solutions utilizing this, if yes then by all means let's include it. I could imagine for instance that sentry's sdk (and others) could be using this to get more information about the request (someone would need to check this) -- but aside from error reporting not much comes to mind that wouldn't be easily worked around manually in code (ie when calling another wsgi app from a django view etc…)

[Anvesh Mishra]

Replying to Florian Apolloner:

Two things that come to mind:

• On a technical level I think if this were to be in core it should be done via django/core/handlers/wsgi where resolve_request could be overwritten to set request.environ/META directly from the returned resolver_match there (unconditionally, I don't see much gain in a middleware and extra setters/getters for such a niche feature).

• On a organizational level I'd like to ask: Do we need this? If someone wants it, there is always request.resolver_match which can be used to copy this data into environ['wsgiorg.routing_args'] as needed.

Given point two I'd like to ask if there are any popular python solutions utilizing this, if yes then by all means let's include it. I could imagine for instance that sentry's sdk (and others) could be using this to get more information about the request (someone would need to check this) -- but aside from error reporting not much comes to mind that wouldn't be easily worked around manually in code (ie when calling another wsgi app from a django view etc…)

Both points made seem fairly resonable so I would just like to ask what would be the future of this ticket? maybe we can have a work around with the resolver_request as stated in point 1.

[Florian Apolloner]

The future depends on whether routing_args are used in the wild; if not it will most likely be a wontfix.

[Anvesh Mishra]

Replying to Florian Apolloner:

The future depends on whether routing_args are used in the wild; if not it will most likely be a wontfix.

Got it

[Tom Carrick]

I ran a quick GitHub code search to see if anyone is using this with Django: ​https://github.com/search?q=%22routing_args%22+language%3APython+django&type=code

My conclusion is "not really".

And it can be done in middleware. So I'm not sure I see much reason to fix this.