Changes between Initial Version and Version 1 of Ticket #11670, comment 16


Ignore:
Timestamp:
Oct 8, 2011, 8:28:46 AM (13 years ago)
Author:
Julien Phalip

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #11670, comment 16

    initial v1  
    1 All tests are now passing. I'm reasonably happy of where the patch is at now. I'm just wondering whether the values fetched from the resolve_lookup_path cache should systematically copied (as currently in the the patch) or if it's should be the calling code's responsibility to make copies before modifying the values -- if the later, then there would probably be a slight speed increase.
     1All tests are now passing. I'm reasonably happy of where the patch is at now. I'm just wondering whether the values fetched from the resolve_lookup_path cache should systematically be copied (as currently in the the patch) or if it should be the calling code's responsibility to make copies before modifying the values -- if the later, then there would probably be a slight speed increase.
    22
    33At this point I'd really like to get the patch reviewed. Any feedback is welcome. Thanks!
Back to Top