Changes between Initial Version and Version 1 of Ticket #11195, comment 4


Ignore:
Timestamp:
03/01/2011 09:17:20 PM (4 years ago)
Author:
ramiro
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #11195, comment 4

    initial v1  
    33> vjimw seems to have a [http://code.djangoproject.com/attachment/ticket/14291/admin_list.py.patch patch] there as well. We should take a look at it and see if he has found a more elegant solution or thought of corner cases I might have missed.
    44
    5 vjimw's patch had no extra functionality compared to yours. Only difference is the class name
     5vjimw's patch had no extra functionality compared to yours. Only difference is in the class name given to the cell, it is the model field name.
    66
    77I've updated the patch with:
     
    99 * Avoid touching the class of the select chebox cell, it is still `'action-checkbox'` instead of being renamed to  `fieldname_action_checkbox'`.
    1010 * Changed class name reparator from `'_'` `'-'` to be consisten with other CSS class names used in the same view.
    11  * Shortened the class name prefix from `'fieldname'` to `'fldname'`. Not completely happy with it, maybe we can use vjimw's approach?
     11 * Shortened the class name prefix from `'fieldname'` to `'fldname'`. Not completely happy with it, maybe we can simply use vjimw's approach?
Back to Top