Changes between Version 1 and Version 2 of Ticket #10200, comment 12


Ignore:
Timestamp:
03/15/2012 02:51:48 PM (3 years ago)
Author:
ramiro
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #10200, comment 12

    v1 v2  
    1 Actually, loaddata code in its current status is such that all error code paths mean:
     1Actually, loaddata code in its current status is such that all error code paths lead to:
    22
    33 * An error is printed to stderr
    44 * The handle() method returns
    55
    6 So, the only (benefical IMHO) change the change proposed by this ticket would be that the Unix process exit code from zero to a non-zero value.
     6So, the only (beneficial IMHO) change the modification proposed by this ticket would introduce would be that the Unix process exit code changes from zero to a non-zero value.
    77
    8 I suspect the backward-incompatibility reservations Jacob had back then were related to the fact that raising !CommandError would mean exiting from the nested loops and aborting execution of the command; but the gradual evolution of the code during the last threee years has resulted is precisely that behavior already
     8I suspect the backward-incompatibility reservations Jacob had back then were related to the fact that raising !CommandError would mean exiting from the nested loops and aborting execution of the command; but the evolution of the code during the last three years has resulted in precisely that behavior already
    99
    1010But I'm not sure. Will try to confirm with him.
Back to Top