Ticket #9171: 9171-inlineformset_factory-r9082.2.diff

django/forms/models.py

@@ -528 +528 @@
     if fk.unique:
         max_num = 1
     if exclude is not None:
+        exclude = list(exclude)
         exclude.append(fk.name)
     else:
         exclude = [fk.name]

django/contrib/admin/options.py

@@ -266 +266 @@
         if self.exclude is None:
             exclude = []
         else:
-            exclude = self.exclude
+            exclude = list(self.exclude)
         defaults = {
             "form": self.form,
             "fields": fields,
@@ -780 +780 @@
         if self.exclude is None:
             exclude = []
         else:
-            exclude = self.exclude
+            exclude = list(self.exclude)
         defaults = {
             "form": self.form,
             "formset": self.formset,

tests/regressiontests/modeladmin/models.py

@@ -123 +123 @@
 >>> ma = BandAdmin(Band, site) 
 >>> ma.get_form(request).base_fields.keys() 
 ['name', 'sign_date']
+
+# You can also pass a tuple to `exclude`.
  
+>>> class BandAdmin(ModelAdmin): 
+...     exclude = ('bio',) 
+>>> ma = BandAdmin(Band, site) 
+>>> ma.get_form(request).base_fields.keys() 
+['name', 'sign_date']
+ 
 # Using `fields` and `exclude`.
 
 >>> class BandAdmin(ModelAdmin): 

tests/regressiontests/inline_formsets/models.py

@@ -51 +51 @@
 Exception: <class 'regressiontests.inline_formsets.models.Child'> has no field named 'test'
 
 
+# Regression test for #9171.
+>>> ifs = inlineformset_factory(Parent, Child, exclude=('school',), fk_name='mother')
 """
 }