Ticket #8898: 8898-DateTimeField-r8966.diff

django/forms/fields.py

@@ -381 +381 @@
             # components: date and time.
             if len(value) != 2:
                 raise ValidationError(self.error_messages['invalid'])
+            if value[0] in EMPTY_VALUES and value[1] in EMPTY_VALUES:
+                if self.required:
+                    raise ValidationError(self.error_messages['required'])
+                return value
             value = '%s %s' % tuple(value)
         for format in self.input_formats:
             try:

tests/regressiontests/forms/fields.py

@@ -619 +619 @@
 >>> repr(f.clean(''))
 'None'
 
+Regression test for #8898.
+>>> f = DateTimeField(widget=SplitDateTimeWidget)
+>>> f.clean(['', ''])
+Traceback (most recent call last):
+...
+ValidationError: [u'This field is required.']
+>>> f = DateTimeField(required=False, widget=SplitDateTimeWidget)
+>>> f.clean(['', ''])
+['', '']
+
 # RegexField ##################################################################
 
 >>> f = RegexField('^\d[A-F]\d$')

AUTHORS

@@ -239 +239 @@
     Eugene Lazutkin <http://lazutkin.com/blog/>
     lcordier@point45.com
     Jeong-Min Lee <falsetru@gmail.com>
+    Tai Lee <real.human@mrmachine.net>
     Jannis Leidel <jl@websushi.org>
     Christopher Lenz <http://www.cmlenz.net/>
     lerouxb@gmail.com
@@ -278 +279 @@
     Aljosa Mohorovic <aljosa.mohorovic@gmail.com>
     Ramiro Morales <rm0@gmx.net>
     Eric Moritz <http://eric.themoritzfamily.com/>
-    mrmachine <real.human@mrmachine.net>
     Robin Munn <http://www.geekforgod.com/>
     James Murty
     msundstr