Ticket #8627: fix_textarea_disappearing_first_empty_line.diff

django/forms/widgets.py

@@ -282 +282 @@
         if value is None: value = ''
         value = force_unicode(value)
         final_attrs = self.build_attrs(attrs, name=name)
-        return mark_safe(u'<textarea%s>%s</textarea>' % (flatatt(final_attrs),
+        return mark_safe(u'<textarea%s>\r\n%s</textarea>' % (flatatt(final_attrs),
                 conditional_escape(force_unicode(value))))
 
 class DateTimeInput(Input):

tests/modeltests/model_forms/models.py

@@ -350 +350 @@
 <option value="1">Mike Royko</option>
 <option value="2">Bob Woodward</option>
 </select></td></tr>
-<tr><th>Article:</th><td><textarea rows="10" cols="40" name="article"></textarea></td></tr>
+<tr><th>Article:</th><td><textarea rows="10" cols="40" name="article">
+</textarea></td></tr>
 <tr><th>Status:</th><td><select name="status">
 <option value="" selected="selected">---------</option>
 <option value="1">Draft</option>
@@ -405 +406 @@
 <option value="1" selected="selected">Mike Royko</option>
 <option value="2">Bob Woodward</option>
 </select></li>
-<li>Article: <textarea rows="10" cols="40" name="article">Hello.</textarea></li>
+<li>Article: <textarea rows="10" cols="40" name="article">
+Hello.</textarea></li>
 <li>Status: <select name="status">
 <option value="" selected="selected">---------</option>
 <option value="1">Draft</option>
@@ -466 +468 @@
 <option value="1" selected="selected">Mike Royko</option>
 <option value="2">Bob Woodward</option>
 </select></li>
-<li>Article: <textarea rows="10" cols="40" name="article">Hello.</textarea></li>
+<li>Article: <textarea rows="10" cols="40" name="article">
+Hello.</textarea></li>
 <li>Status: <select name="status">
 <option value="" selected="selected">---------</option>
 <option value="1">Draft</option>
@@ -582 +585 @@
 <option value="1">Mike Royko</option>
 <option value="2">Bob Woodward</option>
 </select></li>
-<li>Article: <textarea rows="10" cols="40" name="article"></textarea></li>
+<li>Article: <textarea rows="10" cols="40" name="article">
+</textarea></li>
 <li>Status: <select name="status">
 <option value="" selected="selected">---------</option>
 <option value="1">Draft</option>
@@ -608 +612 @@
 <option value="2">Bob Woodward</option>
 <option value="3">Carl Bernstein</option>
 </select></li>
-<li>Article: <textarea rows="10" cols="40" name="article"></textarea></li>
+<li>Article: <textarea rows="10" cols="40" name="article">
+</textarea></li>
 <li>Status: <select name="status">
 <option value="" selected="selected">---------</option>
 <option value="1">Draft</option>

tests/regressiontests/forms/forms.py

@@ -303 +303 @@
 >>> print f['subject']
 <input type="text" name="subject" />
 >>> print f['message']
-<textarea rows="10" cols="40" name="message"></textarea>
+<textarea rows="10" cols="40" name="message">
+</textarea>
 
 as_textarea(), as_text() and as_hidden() are shortcuts for changing the output
 widget type:
 >>> f['subject'].as_textarea()
-u'<textarea rows="10" cols="40" name="subject"></textarea>'
+u'<textarea rows="10" cols="40" name="subject">\r\n</textarea>'
 >>> f['message'].as_text()
 u'<input type="text" name="message" />'
 >>> f['message'].as_hidden()
@@ -320 +321 @@
 ...     message = CharField(widget=Textarea(attrs={'rows': 80, 'cols': 20}))
 >>> f = ContactForm(auto_id=False)
 >>> print f['message']
-<textarea rows="80" cols="20" name="message"></textarea>
+<textarea rows="80" cols="20" name="message">
+</textarea>
 
 Instance-level attrs are *not* carried over to as_textarea(), as_text() and
 as_hidden():
@@ -328 +330 @@
 u'<input type="text" name="message" />'
 >>> f = ContactForm({'subject': 'Hello', 'message': 'I love you.'}, auto_id=False)
 >>> f['subject'].as_textarea()
-u'<textarea rows="10" cols="40" name="subject">Hello</textarea>'
+u'<textarea rows="10" cols="40" name="subject">\r\nHello</textarea>'
 >>> f['message'].as_text()
 u'<input type="text" name="message" value="I love you." />'
 >>> f['message'].as_hidden()