Ticket #8562: 8562_primary_uniques_testupdate.diff

django/forms/models.py

@@ -96 +96 @@
     the ``fields`` argument.
     """
     # avoid a circular import
-    from django.db.models.fields.related import ManyToManyField, OneToOneField
+    from django.db.models.fields.related import ManyToManyField, OneToOneField, ForeignKey
     opts = instance._meta
     data = {}
     for f in opts.fields + opts.many_to_many:
@@ -117 +117 @@
                 data[f.name] = [obj.pk for obj in f.value_from_object(instance)]
         elif isinstance(f, OneToOneField):
             data[f.attname] = f.value_from_object(instance)
+            data[f.name] = data[f.attname]
+        elif isinstance(f, ForeignKey) and f.primary_key and f.unique:
+            data[f.attname] = f.value_from_object(instance)
+            data[f.name] = data[f.attname]
         else:
             data[f.name] = f.value_from_object(instance)
     return data
@@ -319 +323 @@
 
     def add_fields(self, form, index):
         """Add a hidden field for the object's primary key."""
-        if self.model._meta.pk.auto_created:
+        # include both edges ot OneToOne Primary key, and 
+        # ForeignKey, primary key, unique .. which is a OneToOne in reality
+        from django.db.models.fields.related import OneToOneField, ForeignKey
+        if self.model._meta.pk.auto_created or (self.model._meta.pk.primary_key \
+               and ((isinstance(self.model._meta.pk, OneToOneField)) or \
+               (isinstance(self.model._meta.pk, ForeignKey) and self.model._meta.pk.unique))):
             self._pk_field_name = self.model._meta.pk.attname
             form.fields[self._pk_field_name] = IntegerField(required=False, widget=HiddenInput)
         super(BaseModelFormSet, self).add_fields(form, index)

tests/modeltests/model_forms/models.py

@@ -811 +811 @@
 >>> bw = BetterWriter(name=u'Joe Better')
 >>> bw.save()
 >>> sorted(model_to_dict(bw).keys())
-['id', 'name', 'writer_ptr_id']
+['id', 'name', 'writer_ptr', 'writer_ptr_id']
 
 # PhoneNumberField ############################################################