Ticket #7753: nulbool_clean2.diff

django/newforms/fields.py

@@ -582 +582 @@
     widget = NullBooleanSelect
 
     def clean(self, value):
-        return {True: True, False: False}.get(value, None)
+        """Returns a Python boolean object OR None"""
+        # Explicitly check for the string 'True' and 'False', which is what a
+        # hidden field will submit for True and False. Unlike the 
+        # Booleanfield we also need to check for True, because we are not using
+        # the bool() function 
+        if value in (True, 'True'):
+            return True
+        elif value in (False, 'False'):
+            return False
+        else:
+            return None
 
 class ChoiceField(Field):
     widget = Select

tests/regressiontests/forms/fields.py

@@ -1034 +1034 @@
 >>> f.clean('3')
 >>> f.clean('hello')
 
+A form's NullBooleanField with a hidden widget will output the string 'True' 
+for True and 'False' for False, so those should be cleaned to their respective
+Python values
+>>> f.clean('True')
+True
+>>> f.clean('False')
+False
+
 # MultipleChoiceField #########################################################
 
 >>> f = MultipleChoiceField(choices=[('1', '1'), ('2', '2')])