Ticket #6183: newforms-admin_ManyToManyField-widget.patch

django/db/models/fields/related.py

@@ -637 +637 @@
         self.db_table = kwargs.pop('db_table', None)
         Field.__init__(self, **kwargs)
 
-        msg = ugettext_lazy('Hold down "Control", or "Command" on a Mac, to select more than one.')
+        msg = ugettext_lazy('<span class="select-multiple-help-text">Hold down "Control", or "Command" on a Mac, to select more than one.</span>')
         self.help_text = string_concat(self.help_text, ' ', msg)
 
     def get_manipulator_field_objs(self):

django/contrib/admin/media/js/SelectFilter2.js

@@ -14 +14 @@
     return node;
 }
 
+function findSelectMultipleHelpTextNode(node) {
+    var nodes = node.getElementsByTagName('span');
+    for (var i=0, length=nodes.length; i<length; i++) {
+        if (nodes[i].className == 'select-multiple-help-text') {
+            // assume there's only one
+            return nodes[i];
+        }
+    }
+    return null;
+}
+
+function findHelpTextNodes(node) {
+    var nodes = node.getElementsByTagName('p');
+    var result = [];
+    for (var i=0, length=nodes.length; i<length; i++) {
+        if (nodes[i].className == 'help') {
+            result.push(nodes[i]);
+        }
+    }
+    return result;
+}
+
 var SelectFilter = {
     init: function(field_id, field_name, is_stacked, admin_media_prefix) {
         var from_box = document.getElementById(field_id);
         from_box.id += '_from'; // change its ID
         from_box.className = 'filtered';
 
-        // Remove <p class="info">, because it just gets in the way.
-        var ps = from_box.parentNode.getElementsByTagName('p');
-        for (var i=0; i<ps.length; i++) {
-            from_box.parentNode.removeChild(ps[i]);
+        // Find and remove the span tag wich holds the
+        // 'Hold down "Control", or "Command" on a Mac, to select more than one.'
+        // message.
+        var smhelp_node = findSelectMultipleHelpTextNode(from_box.parentNode);
+        if (smhelp_node) {
+            smhelp_node.parentNode.removeChild(smhelp_node);
         }
 
+        // Find and remove all user supplied help_text's.
+        var help_text_nodes = findHelpTextNodes(from_box.parentNode);
+        var removed_nodes = [];
+        for (var i=0, length=help_text_nodes.length; i<length; i++) {
+            removed_nodes.push(help_text_nodes[i].parentNode.removeChild(help_text_nodes[i]));
+        }
+
         // <div class="selector"> or <div class="selector stacked">
         var selector_div = quickElement('div', from_box.parentNode);
         selector_div.className = is_stacked ? 'selector stacked' : 'selector';
@@ -76 +107 @@
         SelectBox.init(field_id + '_to');
         // Move selected from_box options to to_box
         SelectBox.move(field_id + '_from', field_id + '_to');
+
+        // Put the user supplied help_text's back into the dom at a place where they
+        // don't interfere with the SelectFilter widget.
+        for (var i=0, length=removed_nodes.length; i<length; i++) {
+            from_box.parentNode.parentNode.parentNode.appendChild(removed_nodes[i]);
+        }
     },
     filter_key_up: function(event, field_id) {
         from = document.getElementById(field_id + '_from');