Context Navigation

Ticket #5622: empty-ip-2.diff

File empty-ip-2.diff, 2.4 KB (added by jfunk, 14 years ago)
Version that does not break BooleanField

Empty ipaddress raises an error (invalid input syntax for type inet: "")

http://code.djangoproject.com/ticket/5622

-              old
+               class IPAddressField(Field):
         kwargs['max_length'] = 15
         Field.__init__(self, *args, **kwargs)
+    def get_db_prep_value(self, value, connection, prepared=False):
+        if not prepared:
+            value = self.get_prep_value(value)
+        return value or None
     def get_internal_type(self):
         return "IPAddressField"

-              old
+               class BooleanModel(models.Model):
     bfield = models.BooleanField()
     string = models.CharField(max_length=10, default='abc')
+class IP(models.Model):
+    ip = models.IPAddressField(blank=True, null=True)
 ###############################################################################
 # ImageField

-              old
+               from django import forms
 from django.db import models
 from django.core.exceptions import ValidationError
 from models import Foo, Bar, Whiz, BigD, BigS, Image, BigInt, Post, NullBooleanModel, BooleanModel
+from models import Foo, Bar, Whiz, BigD, BigS, Image, BigInt, Post, NullBooleanModel, BooleanModel, IP
 # If PIL available, do these tests.
 if Image:
-…
+               class SlugFieldTests(django.test.TestCas
         bs = BigS.objects.get(pk=bs.pk)
         self.assertEqual(bs.s, 'slug'*50)
+class IPFieldTests(django.test.TestCase):
+    def test_ip_empty(self):
+        """
+        Check it's possible to use empty values in IP field (#5622).
+        """
+        ip = IP.objects.create(ip="")
+        ip = IP.objects.get(pk=ip.pk)
+        self.assertEqual(ip.ip, None)
 class ValidationTest(django.test.TestCase):
     def test_charfield_raises_error_on_empty_string(self):