Ticket #5174: formsets-is_valid-5897.diff

django/newforms/formsets.py

@@ -61 +61 @@
                     kwargs['files'] = self.files
                 add_form = FormClass(**kwargs)
                 self.add_fields(add_form, i)
+                # HACK: Form is empty, lets re-create without data so it doesn't trip validation
+                if self.data and add_form.is_empty():
+                    del(kwargs['data'])
+                    add_form = FormClass(**kwargs)
+                    self.add_fields(add_form, i)
                 add_forms.append(add_form)
             self._add_forms = add_forms
         return self._add_forms
@@ -69 +74 @@
     def _get_change_forms(self):
         """Return a list of all the change forms in this ``FormSet``."""
         FormClass = self.form_class
-        if not hasattr(self, '_add_forms'):
+        if not hasattr(self, '_change_forms'):
             change_forms = []
             for i in range(0, self.change_form_count):
                 kwargs = {'auto_id': self.auto_id, 'prefix': self.add_prefix(i)}
@@ -151 +156 @@
         return '%s-%s' % (self.prefix, index)
 
     def is_valid(self):
+        if not self.is_bound:
+            return False
         self.full_clean()
         return self._is_valid