Ticket #4339: overwrite_existing_files.diff

db/models/base.py

@@ -361 +361 @@
     def _get_FIELD_size(self, field):
         return os.path.getsize(self._get_FIELD_filename(field))
 
-    def _save_FIELD_file(self, field, filename, raw_contents, save=True):
+    def _save_FIELD_file(self, field, filename, raw_contents, save=True, overwrite=False):
         directory = field.get_directory_name()
         try: # Create the date-based directory if it doesn't exist.
             os.makedirs(os.path.join(settings.MEDIA_ROOT, directory))
         except OSError: # Directory probably already exists.
             pass
         filename = field.get_filename(filename)
+        
+        if not overwrite:
+            # If the filename already exists, keep adding an underscore to the name of
+            # the file until the filename doesn't exist.
+            while os.path.exists(os.path.join(settings.MEDIA_ROOT, filename)):
+                try:
+                    dot_index = filename.rindex('.')
+                except ValueError: # filename has no dot
+                    filename += '_'
+                else:
+                    filename = filename[:dot_index] + '_' + filename[dot_index:]
 
-        # If the filename already exists, keep adding an underscore to the name of
-        # the file until the filename doesn't exist.
-        while os.path.exists(os.path.join(settings.MEDIA_ROOT, filename)):
-            try:
-                dot_index = filename.rindex('.')
-            except ValueError: # filename has no dot
-                filename += '_'
-            else:
-                filename = filename[:dot_index] + '_' + filename[dot_index:]
-
         # Write the file to disk.
         setattr(self, field.attname, filename)
 

db/models/fields/__init__.py

@@ -593 +593 @@
         return super(EmailField, self).formfield(**defaults)
 
 class FileField(Field):
-    def __init__(self, verbose_name=None, name=None, upload_to='', **kwargs):
+    def __init__(self, verbose_name=None, name=None, upload_to='', overwrite=False, **kwargs):
         self.upload_to = upload_to
+        self.overwrite = overwrite
         Field.__init__(self, verbose_name, name, **kwargs)
 
     def get_manipulator_fields(self, opts, manipulator, change, name_prefix='', rel=False, follow=True):
@@ -638 +639 @@
         setattr(cls, 'get_%s_filename' % self.name, curry(cls._get_FIELD_filename, field=self))
         setattr(cls, 'get_%s_url' % self.name, curry(cls._get_FIELD_url, field=self))
         setattr(cls, 'get_%s_size' % self.name, curry(cls._get_FIELD_size, field=self))
-        setattr(cls, 'save_%s_file' % self.name, lambda instance, filename, raw_contents, save=True: instance._save_FIELD_file(self, filename, raw_contents, save))
+        setattr(cls, 'save_%s_file' % self.name, lambda instance, filename, raw_contents, save=True, overwrite=self.overwrite: instance._save_FIELD_file(self, filename, raw_contents, save, overwrite))
         dispatcher.connect(self.delete_file, signal=signals.post_delete, sender=cls)
 
     def delete_file(self, instance):