Ticket #3401: char_field_with_choices.patch

django/db/models/fields/__init__.py

@@ -417 +417 @@
         return str(value)
 
     def formfield(self, **kwargs):
-        defaults = {'max_length': self.maxlength, 'required': not self.blank, 'label': capfirst(self.verbose_name), 'help_text': self.help_text}
+        defaults = {'required': not self.blank, 'label': capfirst(self.verbose_name), 'help_text': self.help_text}
         defaults.update(kwargs)
-        return forms.CharField(**defaults)
+        if len(self.choices) == 0:
+            defaults['max_length'] = self.maxlength
+            return forms.CharField(**defaults)
+        else:
+            defaults['choices'] = self.get_choices()
+            return forms.ChoiceField(**defaults)
 
 # TODO: Maybe move this into contrib, because it's specialized.
 class CommaSeparatedIntegerField(CharField):