Ticket #3139: prefix-errors.diff

django/newforms/forms.py

@@ -173 +173 @@
     def __init__(self, form, field, name):
         self.form = form
         self.field = field
-        self.name = form.add_prefix(name)
+        self.name = name
+        self.html_name = form.add_prefix(name)
         self.label = self.field.label or pretty_name(name)
 
     def __unicode__(self):
@@ -201 +202 @@
         auto_id = self.auto_id
         if auto_id and not attrs.has_key('id') and not widget.attrs.has_key('id'):
             attrs['id'] = auto_id
-        return widget.render(self.name, self.data, attrs=attrs)
+        return widget.render(self.html_name, self.data, attrs=attrs)
 
     def as_text(self, attrs=None):
         """
@@ -223 +224 @@
         "Returns the data for this BoundField, or None if it wasn't given."
         if self.field.widget.requires_data_list and isinstance(self.form.data, MultiValueDict):
             return self.form.data.getlist(self.name)
-        return self.form.data.get(self.name, None)
+        return self.form.data.get(self.html_name, None)
     data = property(_data)
 
     def label_tag(self, contents=None):
@@ -251 +252 @@
         """
         auto_id = self.form.auto_id
         if auto_id and '%s' in str(auto_id):
-            return str(auto_id) % self.name
+            return str(auto_id) % self.html_name
         elif auto_id:
             return self.name
         return ''

tests/regressiontests/forms/tests.py

@@ -1975 +1975 @@
 >>> p.is_valid()
 True
 
+Let's try submitting some bad data to make sure form.errors and field.errors
+work as expected.
+>>> data = {
+...     'person1-first_name': u'',
+...     'person1-last_name': u'',
+...     'person1-birthday': u''
+... }
+>>> p = Person(data, prefix='person1')
+>>> len(p.errors)
+3
+>>> print p['first_name'].errors.as_ul()
+<ul class="errorlist"><li>This field is required.</li></ul>
+
 This is pretty unremarkable in and of itself, but let's create some data that
 contains info for two different people.
 >>> data = {