Ticket #2504: get_content_length2.diff

django/http/__init__.py

@@ -240 +240 @@
         if not content_type:
             content_type = "%s; charset=%s" % (settings.DEFAULT_CONTENT_TYPE,
                     settings.DEFAULT_CHARSET)
-        if not isinstance(content, basestring) and hasattr(content, '__iter__'):
+        self._is_file = False
+        if isinstance(content, file):
             self._container = content
-            self._is_string = False
+            self._is_file = True
+        elif not isinstance(content, basestring) and hasattr(content, '__iter__'):
+            self._container = list(content)
         else:
             self._container = [content]
-            self._is_string = True
         self._headers = {'content-type': content_type}
         self.cookies = SimpleCookie()
         if status:
@@ -299 +301 @@
 
     def _get_content(self):
         content = smart_str(''.join(self._container), self._charset)
+        self.content = content
         return content
 
     def _set_content(self, value):
         self._container = [value]
-        self._is_string = True
+        self._is_file = False
 
     content = property(_get_content, _set_content)
 
+    def get_content_length(self):
+        if isinstance(self._container, file):
+            if os.path.exists(self._container.name):
+                return os.path.getsize(self._container.name)
+        return len(self.content)
+
     def __iter__(self):
         self._iterator = iter(self._container)
         return self
@@ -324 +333 @@
     # The remaining methods partially implement the file-like object interface.
     # See http://docs.python.org/lib/bltin-file-objects.html
     def write(self, content):
-        if not self._is_string:
+        if self._is_file:
             raise Exception, "This %s instance is not writable" % self.__class__
         self._container.append(content)
 
@@ -332 +341 @@
         pass
 
     def tell(self):
-        if not self._is_string:
+        if self._is_file:
             raise Exception, "This %s instance cannot tell its position" % self.__class__
         return sum([len(chunk) for chunk in self._container])
 

django/middleware/http.py

@@ -13 +13 @@
     def process_response(self, request, response):
         response['Date'] = formatdate()[:26] + "GMT"
         if not response.has_header('Content-Length'):
-            response['Content-Length'] = str(len(response.content))
+            content_length = response.get_content_length()
+            if content_length is not None:
+                response['Content-Length'] = str(content_length)
 
         if response.has_header('ETag'):
             if_none_match = request.META.get('HTTP_IF_NONE_MATCH', None)

tests/regressiontests/httpwrappers/tests.py

@@ -391 +391 @@
 >>> q.getlist('foo')
 [u'bar', u'\ufffd']
 
+
+>>> r = HttpResponse()
+>>> r.get_content_length()
+0
+
+>>> r = HttpResponse('foo')
+>>> r.get_content_length()
+3
+
+>>> r = HttpResponse('foo')
+>>> r.write('bar')
+>>> r.get_content_length()
+6
+
+>>> r = HttpResponse(['foo', 'bar', 'foobar'])
+>>> r.get_content_length()
+12
+
+>>> r = HttpResponse(file(__file__))
+>>> assert r.get_content_length() > 0
+
+>>> def ten_foos():
+...     for i in range(10): yield 'foo'
+>>> r = HttpResponse(ten_foos())
+>>> r.get_content_length()
+30
+>>> print r.content
+foofoofoofoofoofoofoofoofoofoo
+
 """
 
-from django.http import QueryDict
+from django.http import QueryDict, HttpResponse
 
 if __name__ == "__main__":
     import doctest

docs/request_response.txt

@@ -431 +431 @@
 ``write(content)``, ``flush()`` and ``tell()``
     These methods make an ``HttpResponse`` instance a file-like object.
 
+``get_content_length()``
+    Returns the current length of ``content``.
+
 .. _HTTP Status code: http://www.w3.org/Protocols/rfc2616/rfc2616-sec10.html#sec10
 
 HttpResponse subclasses