Ticket #24263: 24263.diff

django/views/generic/dates.py

@@ -644 +644 @@
                                  day, self.get_day_format())
 
         # Use a custom queryset if provided
-        qs = queryset or self.get_queryset()
+        qs = self.get_queryset() if queryset is None else queryset
 
         if not self.get_allow_future() and date > datetime.date.today():
             raise Http404(_("Future %(verbose_name_plural)s not available because %(class_name)s.allow_future is False.") % {

tests/generic_views/test_dates.py

@@ -602 +602 @@
             '/dates/books/get_object_custom_queryset/2008/oct/01/1/')
         self.assertEqual(res.status_code, 404)
 
+    def test_get_object_custom_queryset_numqueries(self):
+        # Regression test for #24263
+        with self.assertNumQueries(1):
+            self.client.get(
+            '/dates/books/get_object_custom_queryset/2006/may/01/2/')
+
     def test_datetime_date_detail(self):
         bs = BookSigning.objects.create(event_date=datetime.datetime(2008, 4, 2, 12, 0))
         res = self.client.get('/dates/booksignings/2008/apr/2/%d/' % bs.pk)