Ticket #2188: Option 2.diff

core/management.py

@@ -809 +809 @@
     validates all models of all installed apps. Writes errors, if any, to outfile.
     Returns number of errors.
     """
-    from django.db import models
+    from django.db import models, connection
     from django.db.models.fields.related import RelatedObject
+    from django.conf import settings
 
     e = ModelErrorCollection(outfile)
     for cls in models.get_models(app):
@@ -846 +847 @@
             if f.db_index not in (None, True, False):
                 e.add(opts, '"%s": "db_index" should be either None, True or False.' % f.name)
 
+            # Check maxlength < 255 for older MySQL varchar fields
+            if settings.DATABASE_ENGINE == 'mysql':
+                db_version = connection.get_server_version()
+                if db_version < (5, 0, 3):
+                    if isinstance(f, models.CharField) and f.maxlength > 255:
+                        e.add(opts, '"%s": CharFields cannot have a "maxlength" greater than 255 when you are using a version of MySQL older than 5.0.3; you are using %s.' % (f.name, '.'.join(str(n) for n in db_version[:3])))
+                    if isinstance(f, models.CommaSeparatedIntegerField) and f.maxlength > 255:
+                        e.add(opts, '"%s": CommaSeparatedIntegerField cannot have a "maxlength" greater than 255 when you are using a version of MySQL older than 5.0.3; you are using %s.' % (f.name, '.'.join(str(n) for n in db_version[:3])))
+                    if isinstance(f, models.SlugField) and f.maxlength > 255:
+                        e.add(opts, '"%s": SlugField cannot have a "maxlength" greater than 255 when you are using a version of MySQL older than 5.0.3; you are using %s.' % (f.name, '.'.join(str(n) for n in db_version[:3])))
+
             # Check to see if the related field will clash with any
             # existing fields, m2m fields, m2m related objects or related objects
             if f.rel:

db/backends/mysql/base.py

@@ -12 +12 @@
     raise ImproperlyConfigured, "Error loading MySQLdb module: %s" % e
 from MySQLdb.converters import conversions
 from MySQLdb.constants import FIELD_TYPE
-import types
+import types, re
 
 DatabaseError = Database.DatabaseError
 
@@ -61 +61 @@
     def __init__(self):
         self.connection = None
         self.queries = []
+        self.server_version = None
 
     def _valid_connection(self):
         if self.connection is not None:
@@ -95 +96 @@
             return util.CursorDebugWrapper(MysqlDebugWrapper(cursor), self)
         return cursor
 
+    def get_server_version(self):
+        if not self.server_version:
+            if not self._valid_connection():
+                self.cursor()
+            version = re.compile('[\.-]').split(self.connection.get_server_info())
+            self.server_version = tuple(int(x) for x in version[:3]) + tuple(version[3:])
+        return self.server_version
+
     def _commit(self):
         self.connection.commit()