Ticket #20528: 20528-test-master.diff

tests/select_related_regress/models.py

@@ -95 +95 @@
     def __str__(self):
         return self.name
 
+class ChildA(models.Model):
+    parent = models.ForeignKey(Parent)
+
+@python_2_unicode_compatible
+class ChildB(models.Model):
+    name = models.CharField(max_length=10)
+    parent = models.ForeignKey(Parent, null=True)
+    child = models.ForeignKey(ChildA, null=True)
+
+    def __str__(self):
+        return self.name
+
 # Models for testing bug #19870.
 @python_2_unicode_compatible
 class Fowl(models.Model):

tests/select_related_regress/tests.py

@@ -1 +1 @@
 from __future__ import absolute_import, unicode_literals
 
+from django.db import models
 from django.test import TestCase
 from django.utils import six
 
 from .models import (Building, Child, Device, Port, Item, Country, Connection,
     ClientStatus, State, Client, SpecialClient, TUser, Person, Student,
-    Organizer, Class, Enrollment, Hen, Chick)
+    Organizer, Class, Enrollment, Hen, Chick, Parent, ChildA, ChildB)
 
 
 class SelectRelatedRegressTests(TestCase):
@@ -173 +174 @@
 
         self.assertEqual(Chick.objects.all()[0].mother.name, 'Hen')
         self.assertEqual(Chick.objects.select_related()[0].mother.name, 'Hen')
+
+    def test_ticket_20528(self):
+        """
+        Regression for #20528
+
+        Using Qs and select_related with a certain config of ForeignKeys
+        resulted in incorrect joins.
+        """
+        parent = Parent.objects.create(name="foo")
+        childA = ChildA.objects.create(parent=parent)
+        childB = ChildB.objects.create(child=childA, name="Bobby")
+        queryset = ChildB.objects.filter(
+            models.Q(parent=parent) | models.Q(child__parent=parent)
+        )
+        expected_queryset = ['<ChildB: Bobby>']
+        # this always works
+        self.assertQuerysetEqual(queryset, expected_queryset)
+
+        # this started failing after 3fef304ff237fe692459c1f5b840acf7886c50bb
+        queryset = queryset.select_related('parent')
+        import sys
+        sys.stderr.write(str(queryset.query))
+        self.assertQuerysetEqual(queryset, expected_queryset)