Context Navigation

Ticket #19875: 19875.3.diff

File 19875.3.diff, 2.8 KB (added by Tim Graham, 11 years ago)

diff --git a/django/core/management/commands/runserver.py b/django/core/management/commands/runserver.py
index c4a0b78..ad90e19 100644

                class Command(BaseCommand):
         from django.conf import settings
         from django.utils import translation
+        if not settings.DEBUG and not settings.ALLOWED_HOSTS:
+            self.stderr.write('You must set settings.ALLOWED_HOSTS if DEBUG is False.')
+            sys.exit(1)
         threading = options.get('use_threading')
         shutdown_message = options.get('shutdown_message', '')
         quit_command = 'CTRL-BREAK' if sys.platform == 'win32' else 'CONTROL-C'

diff --git a/docs/intro/tutorial03.txt b/docs/intro/tutorial03.txt
index 1203691..6193ec4 100644

                template for all 404 errors when :setting:`DEBUG` is set to ``False`` (in your
 settings module). If you do create the template, add at least some dummy
 content like "Page not found".
+.. warning::
+    If :setting:`DEBUG` is set to ``False``, all responses will be
+    "Bad Request (400)" unless you specify the proper :setting:`ALLOWED_HOSTS`
+    as well (something like ``['localhost', '127.0.0.1']`` for
+    local development).
 A couple more things to note about 404 views:
 * If :setting:`DEBUG` is set to ``True`` (in your settings module) then your

diff --git a/docs/ref/settings.txt b/docs/ref/settings.txt
index ef52d31..897af27 100644

                It is also important to remember that when running with :setting:`DEBUG`
 turned on, Django will remember every SQL query it executes. This is useful
 when you're debugging, but it'll rapidly consume memory on a production server.
+Finally, if :setting:`DEBUG` is ``False``, you also need to properly set
+the :setting:`ALLOWED_HOSTS` setting. Failing to do so will result in all
+requests being returned as "Bad Request (400)".
 .. _django/views/debug.py: https://github.com/django/django/blob/master/django/views/debug.py
 .. setting:: DEBUG_PROPAGATE_EXCEPTIONS

diff --git a/docs/topics/settings.txt b/docs/topics/settings.txt
index fa26297..1cfcd26 100644

                Here are a couple of example settings::
     DEFAULT_FROM_EMAIL = 'webmaster@example.com'
     TEMPLATE_DIRS = ('/home/templates/mike', '/home/templates/john')
+.. note::
+    If you set :setting:`DEBUG` to ``False``, you also need to properly set
+    the :setting:`ALLOWED_HOSTS` setting.
 Because a settings file is a Python module, the following apply:
 * It doesn't allow for Python syntax errors.