Ticket #17864: hkphonenumber.2.diff

new file django/contrib/localflavor/hk/forms.py

@@ +1 @@
+"""
+Hong Kong specific Form helpers
+"""
+from __future__ import absolute_import
+
+import re
+
+from django.core.validators import EMPTY_VALUES
+from django.forms import CharField
+from django.forms import ValidationError
+from django.utils.encoding import smart_unicode
+from django.utils.translation import ugettext_lazy as _
+
+
+hk_phone_digits_re = re.compile(r'^(?:852-?)?(\d{4})[-\.]?(\d{4})$')
+hk_special_numbers = ('999', '992', '112')
+hk_phone_prefixes = ('2', '3', '5', '6', '8', '9')
+
+
+class HKPhoneNumberField(CharField):
+    """
+    Validate Hong Kong phone number.
+    The input format can be either one of the followings:
+    'XXXX-XXXX', '852-XXXX-XXXX', '(+852) XXXX-XXXX',
+    'XXXX XXXX', or 'XXXXXXXX'.
+    The output format is 'XXXX-XXXX'.
+
+    Note: The phone number shall not start with 999, 992, or 112.
+          And, it should start with either 2, 3, 5, 6, 8, or 9.
+
+    Ref - http://en.wikipedia.org/wiki/Telephone_numbers_in_Hong_Kong
+    """
+    default_error_messages = {
+        'disguise': _('Phone number should not start with ' \
+                    'one of the followings: %s.' % \
+                    ', '.join(hk_special_numbers)),
+        'invalid': _('Phone number must be in XXXX-XXXX format.'),
+        'prefix': _('Phone number should start with ' \
+                  'one of the followings: %s.' % \
+                  ', '.join(hk_phone_prefixes)),
+    }
+
+    def __init__(self, *args, **kwargs):
+        super(HKPhoneNumberField, self).__init__(*args, **kwargs)
+
+    def clean(self, value):
+        super(HKPhoneNumberField, self).clean(value)
+
+        if value in EMPTY_VALUES:
+            return u''
+
+        value = re.sub('(\(|\)|\s+|\+)', '', smart_unicode(value))
+        m = hk_phone_digits_re.search(value)
+        if not m:
+            raise ValidationError(self.error_messages['invalid'])
+
+        value = u'%s-%s' % (m.group(1), m.group(2))
+        for special in hk_special_numbers:
+            if value.startswith(special):
+                raise ValidationError(self.error_messages['disguise'])
+
+        prefix_found = map(lambda prefix: value.startswith(prefix),
+                           hk_phone_prefixes)
+        if not any(prefix_found):
+            raise ValidationError(self.error_messages['prefix'])
+
+        return value

docs/ref/contrib/localflavor.txt

@@ -51 +51 @@
 * Finland_
 * France_
 * Germany_
+* `Hong Kong`_
 * Iceland_
 * India_
 * Indonesia_
@@ -108 +109 @@
 .. _Finland: `Finland (fi)`_
 .. _France: `France (fr)`_
 .. _Germany: `Germany (de)`_
+.. _Hong Kong: `Hong Kong (hk)`_
 .. _The Netherlands: `The Netherlands (nl)`_
 .. _Iceland: `Iceland (is\_)`_
 .. _India: `India (in\_)`_
@@ -560 +562 @@
 
     A ``Select`` widget that uses a list of German states as its choices.
 
+Hong Kong (``hk``)
+=================================
+
+.. class:: hk.forms.HKPhoneNumberField
+
+    A form field that validates input as a Hong Kong phone number.
+
+
 The Netherlands (``nl``)
 ========================
 

new file tests/regressiontests/localflavor/hk/forms.py

@@ +1 @@
+from __future__ import absolute_import
+
+from django.forms import ModelForm
+
+from .models import HKPlace
+
+
+class HKPlaceForm(ModelForm):
+
+    class Meta:
+        model = HKPlace

new file tests/regressiontests/localflavor/hk/tests.py

@@ +1 @@
+from __future__ import absolute_import
+
+from django.contrib.localflavor.hk.forms import HKPhoneNumberField
+from django.test import SimpleTestCase
+
+
+class HKLocalFlavorTests(SimpleTestCase):
+    """Tests for Hong Kong Local Flavors"""
+
+    def test_HKPhoneNumberField(self):
+        error_msgs = HKPhoneNumberField.default_error_messages
+        valid = {
+            '2111-1111': '2111-1111',
+            '3111 1111': '3111-1111',
+            '51111111': '5111-1111',
+            '852-6111-1111': '6111-1111',
+            '(+852) 8111-1111': '8111-1111',
+            '(+852) 9111-1111': '9111-1111',
+        }
+        invalid = {
+            '9991-1111': [error_msgs['disguise'], ],
+            '9921-1111': [error_msgs['disguise'], ],
+            '1121-1111': [error_msgs['disguise'], ],
+            '1': [error_msgs['invalid'], ],
+            '1111 1111': [error_msgs['prefix'], ],
+        }
+        self.assertFieldOutput(HKPhoneNumberField, valid, invalid)

tests/regressiontests/localflavor/tests.py

@@ -18 +18 @@
 from .fr.tests import FRLocalFlavorTests
 from .gb.tests import GBLocalFlavorTests
 from .generic.tests import GenericLocalFlavorTests
+from .hk.tests import HKLocalFlavorTests
 from .hr.tests import HRLocalFlavorTests
 from .id.tests import IDLocalFlavorTests
 from .ie.tests import IELocalFlavorTests