Ticket #17648: ticket-17648-correctly-handle-deferred-proxies.2.diff

django/contrib/contenttypes/models.py

@@ -16 +16 @@
         return ct
 
     def _get_opts(self, model):
-        opts = model._meta
-        while opts.proxy:
-            model = opts.proxy_for_model
-            opts = model._meta
-        return opts
+        if model._deferred:
+            # Options must be retreived from the base class for deferred models
+            # since they're really just dynamic wrappers and should not have 
+            # their own conten-type.
+            model = model.__class__.__bases__[0]
+        return model._meta
 
     def _get_from_cache(self, opts):
         key = (opts.app_label, opts.object_name.lower())

tests/modeltests/proxy_models/tests.py

@@ -217 +217 @@
         signals.post_save.disconnect(h6, sender=MyPersonProxy)
 
     def test_content_type(self):
+        # A model and a proxy of this model do not
+        # share the same ContentType see #17648
         ctype = ContentType.objects.get_for_model
-        self.assertTrue(ctype(Person) is ctype(OtherPerson))
+        self.assertFalse(ctype(Person) is ctype(OtherPerson))
 
     def test_user_userproxy_userproxyproxy(self):
         User.objects.create(name='Bruce')

tests/regressiontests/defer_regress/tests.py

@@ -169 +169 @@
         self.assertEqual(dp.name, proxy.name, msg=msg)
         self.assertEqual(dp.value, proxy.value, msg=msg)
 
+        # Instances of proxy models with deferred fields should
+        # return the content type of the proxy model (bug #17648)
+        ctype = ContentType.objects.get_for_model
+        c1 = ctype(Proxy.objects.all()[0])
+        c2 = ctype(Proxy.objects.defer("name")[0])
+        c3 = ctype(Proxy.objects.only("name")[0])
+        self.assertTrue(c1 is c2 is c3)
+
     def test_resolve_columns(self):
         rt = ResolveThis.objects.create(num=5.0, name='Foobar')
         qs = ResolveThis.objects.defer('num')