Ticket #17046: patch_for_17046_another.diff

django/contrib/auth/models.py

@@ -121 +121 @@
         Creates and saves a User with the given username, email and password.
         """
         now = timezone.now()
+        if not username:
+            raise ValueError('Username cannot be an empty string.')
 
         # Normalize the address by lowercasing the domain part of the email
         # address.

django/contrib/auth/tests/__init__.py

@@ -10 +10 @@
 from django.contrib.auth.tests.remote_user import (RemoteUserTest,
     RemoteUserNoCreateTest, RemoteUserCustomTest)
 from django.contrib.auth.tests.management import GetDefaultUsernameTestCase
-from django.contrib.auth.tests.models import ProfileTestCase
+from django.contrib.auth.tests.models import (ProfileTestCase,
+    UserEmptyUsernameCase)
 from django.contrib.auth.tests.hashers import TestUtilsHashPass
 from django.contrib.auth.tests.signals import SignalTestCase
 from django.contrib.auth.tests.tokens import TokenGeneratorTest

django/contrib/auth/tests/models.py

@@ -33 +33 @@
         # module that doesn't exist
         settings.AUTH_PROFILE_MODULE = 'foo.bar'
         self.assertRaises(SiteProfileNotAvailable, user.get_profile)
+
+
+class UserEmptyUsernameCase(TestCase):
+    def test_empty_username(self):
+        self.assertRaisesMessage(ValueError,
+                                 'Username cannot be an empty string.',
+                                 User.objects.create_user, username='')