Ticket #16436: 16436-annotate-select_related-only-r16522.diff

tests/regressiontests/defer_annotate_select_related/tests.py

@@ +1 @@
+from django.db.models import Count
+from django.test import TestCase
+from models import *
+
+class DeferAnnotateSelectRelatedTest(TestCase):
+    def test(self):
+        location = Location.objects.create()
+        request = Request.objects.create(location=location)
+        self.assertIsInstance(list(Request.objects
+            .annotate(Count('items')).select_related('profile', 'location')
+            .only('profile', 'location')), list)
+        self.assertIsInstance(list(Request.objects
+            .annotate(Count('items')).select_related('profile', 'location')
+            .only('profile__profile1', 'location__location1')), list)
+        self.assertIsInstance(list(Request.objects
+            .annotate(Count('items')).select_related('profile', 'location')
+            .defer('request1', 'request2', 'request3', 'request4')), list)

tests/regressiontests/defer_annotate_select_related/models.py

@@ +1 @@
+from django.db import models
+
+class Profile(models.Model):
+    profile1 = models.TextField(default='profile1')
+
+class Location(models.Model):
+    location1 = models.TextField(default='location1')
+
+class Item(models.Model):
+    pass
+
+class Request(models.Model):
+    profile = models.ForeignKey(Profile, null=True, blank=True)
+    location = models.ForeignKey(Location)
+    items = models.ManyToManyField(Item)
+
+    request1 = models.TextField(default='request1')
+    request2 = models.TextField(default='request2')
+    request3 = models.TextField(default='request3')
+    request4 = models.TextField(default='request4')

django/db/models/sql/compiler.py

@@ -717 +717 @@
                     row = self.resolve_columns(row, fields)
 
                 if has_aggregate_select:
-                    aggregate_start = len(self.query.extra_select.keys()) + len(self.query.select)
+                    loaded_fields = self.query.get_loaded_field_names().get(self.query.model, set()) or self.query.select
+                    aggregate_start = len(self.query.extra_select.keys()) + len(loaded_fields)
                     aggregate_end = aggregate_start + len(self.query.aggregate_select)
                     row = tuple(row[:aggregate_start]) + tuple([
                         self.query.resolve_aggregate(value, aggregate, self.connection)