Ticket #15696: with-tests.patch

django/core/management/commands/loaddata.py

@@ -6 +6 @@
 
 from django.conf import settings
 from django.core import serializers
+from django.core.serializers.signals import pre_insert
 from django.core.management.base import BaseCommand
 from django.core.management.color import no_style
 from django.db import connections, router, transaction, DEFAULT_DB_ALIAS
@@ -171 +172 @@
                                     if router.allow_syncdb(using, obj.object.__class__):
                                         loaded_objects_in_fixture += 1
                                         models.add(obj.object.__class__)
+                                        pre_insert.send(self, instance=obj.object)
                                         obj.save(using=using)
                                 loaded_object_count += loaded_objects_in_fixture
                                 fixture_object_count += objects_in_fixture

new file django/core/serializers/signals.py

@@ +1 @@
+from django.dispatch import Signal
+
+pre_insert = Signal(providing_args=['instance'])

tests/regressiontests/fixtures_regress/tests.py

@@ -363 +363 @@
             % widget.pk
             )
 
+    def test_pre_insert_signal(self):
+        """
+        Test for ticket #15696 - deserialized objects may be manipulated before
+        committing them to database using the pre_insert signal
+        """
+        from django.core.serializers.signals import pre_insert
+        def callback(signal, sender, instance):
+            instance.name = 'hello'
+        pre_insert.connect(callback)
+        try:
+            management.call_command(
+                'loaddata',
+                'thingy.json',
+                verbosity=0,
+                commit=False
+            )
+            self.assertEqual(Thingy.objects.get().name, u'hello')
+        finally:
+            pre_insert.disconnect(callback)
+
 
 class NaturalKeyFixtureTests(TestCase):
     def assertRaisesMessage(self, exc, msg, func, *args, **kwargs):