Ticket #14497: 14497.admin-filewidget-readonly.diff

django/contrib/admin/util.py

@@ -329 +329 @@
         return formats.number_format(value, field.decimal_places)
     elif isinstance(field, models.FloatField):
         return formats.number_format(value)
+    elif isinstance(field, models.FileField):
+        return mark_safe(u'<a href="%s">%s</a>'
+                         % (escape(value.url),
+                            escape(force_unicode(value))))
     else:
         return smart_unicode(value)
 

new file tests/regressiontests/admin_widgets/readonly_widgetadmin.py

@@ +1 @@
+"""
+
+"""
+from __future__ import absolute_import
+
+from django.contrib import admin
+
+from . import models
+
+
+class WidgetAdmin(admin.AdminSite):
+    pass
+
+class AlbumAdmin(admin.ModelAdmin):
+    readonly_fields = ('cover_art',)
+
+site = WidgetAdmin(name='rowidget-admin')
+
+site.register(models.Member)
+site.register(models.Band)
+site.register(models.Album, AlbumAdmin)

tests/regressiontests/admin_widgets/tests.py

@@ -18 +18 @@
 
 from . import models
 from .widgetadmin import site as widget_admin_site
+from django.test.client import Client
 
 
 admin_media_prefix = lambda: {
@@ -262 +263 @@
                 )
 
 
-class AdminFileWidgetTest(DjangoTestCase):
+class AdminFileWidgetTests(DjangoTestCase):
+    fixtures = ['admin-widgets-users.xml']
+    urls = "regressiontests.admin_widgets.urls"
+
     def test_render(self):
         band = models.Band.objects.create(name='Linkin Park')
         album = band.album_set.create(
@@ -280 +284 @@
             '<input type="file" name="test" />',
         )
 
+    def test_readonly(self):
+        """File widgets should render as a link when they're marked Read Only
+        """
+
+        band = models.Band.objects.create(name='Linkin Park')
+        album = band.album_set.create(
+            name='Hybrid Theory', cover_art=r'albums\hybrid_theory.jpg'
+        )
+        client = Client()
+        client.login(username='super', password='secret')
+        resp = client.get('/ro-admin/admin_widgets/album/%s/' % album.id)
+        self.assertContains(resp,
+                            '<p><a href="%(STORAGE_URL)salbums/hybrid_theory.jpg">albums\hybrid_theory.jpg</a></p>' % { 'STORAGE_URL': default_storage.url('') },
+                            html=True)
+        self.assertNotContains(resp,
+                               '<input type="file" name="cover_art" id="id_cover_art" />',
+                               html=True)
+
 
 class ForeignKeyRawIdWidgetTest(DjangoTestCase):
     def test_render(self):

tests/regressiontests/admin_widgets/urls.py

@@ -2 +2 @@
 
 from django.conf.urls import patterns, include
 
-from . import  widgetadmin
+from . import  widgetadmin, readonly_widgetadmin
 
 
 urlpatterns = patterns('',
     (r'^', include(widgetadmin.site.urls)),
+    (r'^ro-admin/', include(readonly_widgetadmin.site.urls)),
 )