Ticket #14497: 14497-admin-filewidget-readonly.diff

django/contrib/admin/utils.py

@@ -13 +13 @@
 from django.utils.text import capfirst
 from django.utils import timezone
 from django.utils.encoding import force_str, force_text, smart_text
+from django.utils.safestring import mark_safe
 from django.utils import six
 from django.utils.translation import ungettext
 from django.core.urlresolvers import reverse, NoReverseMatch
@@ -375 +376 @@
         return formats.number_format(value, field.decimal_places)
     elif isinstance(field, models.FloatField):
         return formats.number_format(value)
+    elif isinstance(field, models.FileField):
+        return mark_safe('<a href="%s">%s</a>' % (value.url, value))
     else:
         return smart_text(value)
 

tests/admin_widgets/tests.py

@@ -370 +370 @@
         )
 
 
-class AdminFileWidgetTest(DjangoTestCase):
-    def test_render(self):
+@override_settings(PASSWORD_HASHERS=('django.contrib.auth.hashers.SHA1PasswordHasher',))
+class AdminFileWidgetTests(DjangoTestCase):
+    fixtures = ['admin-widgets-users.xml']
+    urls = "admin_widgets.urls"
+
+    def setUp(self):
         band = models.Band.objects.create(name='Linkin Park')
-        album = band.album_set.create(
+        self.album = band.album_set.create(
             name='Hybrid Theory', cover_art=r'albums\hybrid_theory.jpg'
         )
 
+    def test_render(self):
         w = widgets.AdminFileWidget()
         self.assertHTMLEqual(
-            w.render('test', album.cover_art),
+            w.render('test', self.album.cover_art),
             '<p class="file-upload">Currently: <a href="%(STORAGE_URL)salbums/hybrid_theory.jpg">albums\hybrid_theory.jpg</a> <span class="clearable-file-input"><input type="checkbox" name="test-clear" id="test-clear_id" /> <label for="test-clear_id">Clear</label></span><br />Change: <input type="file" name="test" /></p>' % {
                 'STORAGE_URL': default_storage.url('')
             },
@@ -390 +395 @@
             '<input type="file" name="test" />',
         )
 
+    def test_readonly(self):
+        """
+        File widgets should render as a link when they're marked Read Only
+        """
+
+        self.client.login(username="super", password="secret")
+        response = self.client.get('/admin_widgets/album/%s/' % self.album.id)
+        self.assertContains(response,
+                            '<p><a href="%(STORAGE_URL)salbums/hybrid_theory.jpg">albums\hybrid_theory.jpg</a></p>' % { 'STORAGE_URL': default_storage.url('') },
+                            html=True)
+        self.assertNotContains(response,
+                               '<input type="file" name="cover_art" id="id_cover_art" />',
+                               html=True)
+
 
 class ForeignKeyRawIdWidgetTest(DjangoTestCase):
     urls = 'admin_widgets.urls'

tests/admin_widgets/widgetadmin.py

@@ -23 +23 @@
 class EventAdmin(admin.ModelAdmin):
     raw_id_fields = ['main_band', 'supporting_bands']
 
+class AlbumAdmin(admin.ModelAdmin):
+    fields = ('name', 'cover_art',)
+    readonly_fields = ('cover_art',)
 
 class SchoolAdmin(admin.ModelAdmin):
     filter_vertical = ('students',)
@@ -37 +40 @@
 site.register(models.Member)
 site.register(models.Band)
 site.register(models.Event, EventAdmin)
-site.register(models.Album)
+site.register(models.Album, AlbumAdmin)
 
 site.register(models.Inventory)