Ticket #13918: 13918_simpler_get_model_form.diff

create_update.py

@@ -1 @@
-from django.forms.models import ModelFormMetaclass, ModelForm
+from django.forms.models import  modelform_factory
 from django.template import RequestContext, loader
 from django.http import Http404, HttpResponse, HttpResponseRedirect
 from django.core.xheaders import populate_xheaders
@@ -33 +33 @@
     if form_class:
         return form_class._meta.model, form_class
     if model:
-        # The inner Meta class fails if model = model is used for some reason.
-        tmp_model = model
-        # TODO: we should be able to construct a ModelForm without creating
-        # and passing in a temporary inner class.
-        class Meta:
-            model = tmp_model
-        class_name = model.__name__ + 'Form'
-        form_class = ModelFormMetaclass(class_name, (ModelForm,), {'Meta': Meta})
+        form_class = modelform_factory(model)
         return model, form_class
     raise GenericViewError("Generic view must be called with either a model or"
                            " form_class argument.")