Ticket #13857: default-umask.diff

django/core/files/storage.py

@@ -181 +181 @@
                 # OK, the file save worked. Break out of the loop.
                 break
 
-        if settings.FILE_UPLOAD_PERMISSIONS is not None:
-            os.chmod(full_path, settings.FILE_UPLOAD_PERMISSIONS)
+        mode = settings.FILE_UPLOAD_PERMISSIONS 
+        if not mode:
+            # Read the system default by setting it, then set it back
+            mode = os.umask(0644)
+            os.umask(mode) 
+        os.chmod(full_path, mode)
 
         return name
 

docs/topics/http/file-uploads.txt

@@ -149 +149 @@
         more information about what these modes mean, see the `documentation for
         os.chmod`_
 
-        If this isn't given or is ``None``, you'll get operating-system
-        dependent behavior. On most platforms, temporary files will have a mode
-        of ``0600``, and files saved from memory will be saved using the
-        system's standard umask.
-
+        Defaults to system's current umask, as returned by `os.umask`_.
+            
         .. warning::
 
             If you're not familiar with file modes, please note that the leading
@@ -177 +174 @@
         files."
 
 .. _documentation for os.chmod: http://docs.python.org/library/os.html#os.chmod
+.. _os.umask: http://docs.python.org/library/os.html#os.umask
 
 ``UploadedFile`` objects
 ========================