Ticket #13828: 13828_dry_dictsort_2.diff

django/template/defaultfilters.py

@@ -459 +459 @@
 # LISTS           #
 ###################
 
-def dictsort(value, arg):
+def _dictsort(value, arg, reverse=False):
     """
     Takes a list of dicts, returns that list sorted by the property given in
     the argument.
+    The returned list will be in reverse order if `reverse` is `True`.
     """
     var_resolve = Variable(arg).resolve
-    decorated = [(var_resolve(item), item) for item in value]
-    decorated.sort()
-    return [item[1] for item in decorated]
+    value.sort(key=lambda item: var_resolve(item), reverse=reverse)
+    return value
+
+def dictsort(value, arg):
+    """
+    Takes a list of dicts, returns that list sorted by the property given in
+    the argument.
+    """
+    return _dictsort(value, arg, reverse=False)
 dictsort.is_safe = False
 
 def dictsortreversed(value, arg):
@@ -475 +482 @@
     Takes a list of dicts, returns that list sorted in reverse order by the
     property given in the argument.
     """
-    var_resolve = Variable(arg).resolve
-    decorated = [(var_resolve(item), item) for item in value]
-    decorated.sort()
-    decorated.reverse()
-    return [item[1] for item in decorated]
+    return _dictsort(value, arg, reverse=True)
 dictsortreversed.is_safe = False
 
 def first(value):