Ticket #1258: mssql-django.patch

django/core/meta/__init__.py

@@ -995 +995 @@
     record_exists = True
     if pk_set:
         # Determine whether a record with the primary key already exists.
-        cursor.execute("SELECT 1 FROM %s WHERE %s=%%s LIMIT 1" % \
-            (db.db.quote_name(opts.db_table), db.db.quote_name(opts.pk.column)), [pk_val])
+        if settings.DATABASE_ENGINE == "mssql":
+            cursor.execute("SELECT TOP 1 1 FROM %s WHERE %s=%%s " % (db.db.quote_name(opts.db_table), db.db.quote_name(opts.pk.column)), [pk_val])
+        else:
+            cursor.execute("SELECT 1 FROM %s WHERE %s=%%s LIMIT 1" % \
+                (db.db.quote_name(opts.db_table), db.db.quote_name(opts.pk.column)), [pk_val])
         # If it does already exist, do an UPDATE.
         if cursor.fetchone():
             db_values = [f.get_db_prep_save(f.pre_save(getattr(self, f.attname), False)) for f in non_pks]
@@ -1021 +1024 @@
             placeholders.append('(SELECT COUNT(*) FROM %s WHERE %s = %%s)' % \
                 (db.db.quote_name(opts.db_table), db.db.quote_name(opts.order_with_respect_to.column)))
             db_values.append(getattr(self, opts.order_with_respect_to.attname))
+        if  settings.DATABASE_ENGINE=="mssql" and opts.has_auto_field and pk_set:
+            cursor.execute("SET IDENTITY_INSERT %s ON" % \
+                (db.db.quote_name(opts.db_table)))
         cursor.execute("INSERT INTO %s (%s) VALUES (%s)" % \
             (db.db.quote_name(opts.db_table), ','.join(field_names),
             ','.join(placeholders)), db_values)
+        if  settings.DATABASE_ENGINE=="mssql" and opts.has_auto_field and pk_set:
+            cursor.execute("SET IDENTITY_INSERT %s OFF" % \
+                (db.db.quote_name(opts.db_table)))
         if opts.has_auto_field and not pk_set:
             setattr(self, opts.pk.attname, db.get_last_insert_id(cursor, opts.db_table, opts.pk.column))
     db.db.commit()
@@ -1640 +1649 @@
     order_by = ", ".join(order_by)
 
     # LIMIT and OFFSET clauses
-    if kwargs.get('limit') is not None:
-        limit_sql = " %s " % db.get_limit_offset_sql(kwargs['limit'], kwargs.get('offset'))
+    limit_sql = ""
+    if settings.DATABASE_ENGINE=="mssql":
+        # TODO: this should probably be added to the backend module for better maintenance maybe like?
+        # select, where, limit_sql = db.limit_and_offset(kwargs.get('limit'), kwargs.get('offset'), opts, tables, select, where, order_by)
+        # maybe someone who knows the internals of django better should decide?
+        if kwargs.get('limit') is not None:
+            select[0] = 'TOP %s %s' % (kwargs['limit'], select[0])
+            if kwargs.get('offset') is not None and kwargs['offset'] != 0:
+                #hopefully this is correct, the problems I see here are:
+                #if there is no PK in this table or if user adds GROUP BY, HAVING etc (can he do that?), 
+                #those should be added to the subquery too and they can't be or at least I don't see how 
+                #anyway I believe Group By doesn't make sense in get_object/list but some other where it might 
+                try: 
+                    pkName = opts.pk.name #TODO: is this right?
+                except:
+                    raise NotImplementedError, "This table (%s) must have a primary key in order to do OFFSET when using mssql database provider" % opts.db_table
+                else:
+                    where.append("[%s].%s NOT IN (SELECT TOP %s [%s].%s FROM %s%s%s)" % (opts.db_table, pkName, kwargs['offset'], opts.db_table, pkName, ",".join(tables), (where and " WHERE " + " AND ".join(where) or ""), (order_by and " ORDER BY " + order_by or ""))) 
     else:
-        assert kwargs.get('offset') is None, "'offset' is not allowed without 'limit'"
-        limit_sql = ""
+        if kwargs.get('limit') is not None:
+            limit_sql = " %s " % db.get_limit_offset_sql(kwargs['limit'], kwargs.get('offset'))
+        else:
+            assert kwargs.get('offset') is None, "'offset' is not allowed without 'limit'"
+            limit_sql = ""
 
     return select, " FROM " + ",".join(tables) + (where and " WHERE " + " AND ".join(where) or "") + (order_by and " ORDER BY " + order_by or "") + limit_sql, params
 

django/core/meta/fields.py

@@ -22 +22 @@
 RECURSIVE_RELATIONSHIP_CONSTANT = 'self'
 
 # prepares a value for use in a LIKE query
-prep_for_like_query = lambda x: str(x).replace("%", "\%").replace("_", "\_")
+if settings.DATABASE_ENGINE == "mssql":
+    prep_for_like_query = lambda x: str(x).replace("%", "[%]").replace("_", "[_]")
+else:
+    prep_for_like_query = lambda x: str(x).replace("%", "\%").replace("_", "\_")
 
 # returns the <ul> class for a given radio_admin value
 get_ul_class = lambda x: 'radiolist%s' % ((x == HORIZONTAL) and ' inline' or '')

tests/runtests.py

@@ -206 +206 @@
 if __name__ == "__main__":
     from optparse import OptionParser
     usage = "%prog [options] [model model model ...]"
-    parser = OptionParser()
+    parser = OptionParser(usage=usage)
     parser.add_option('-v', help='How verbose should the output be? Choices are 0, 1 and 2, where 2 is most verbose. Default is 0.',
         type='choice', choices=['0', '1', '2'])
     parser.add_option('--settings',