Ticket #12148: auth_get_user_patch.diff

django/contrib/auth/__init__.py

@@ -1 +1 @@
 import datetime
+from django.conf import settings
 from django.core.exceptions import ImproperlyConfigured
 from django.utils.importlib import import_module
 
@@ -22 +23 @@
     return cls()
 
 def get_backends():
-    from django.conf import settings
     backends = []
     for backend_path in settings.AUTHENTICATION_BACKENDS:
         backends.append(load_backend(backend_path))
@@ -83 +83 @@
     try:
         user_id = request.session[SESSION_KEY]
         backend_path = request.session[BACKEND_SESSION_KEY]
-        backend = load_backend(backend_path)
-        user = backend.get_user(user_id) or AnonymousUser()
+        if backend_path in settings.AUTHENTICATION_BACKENDS:
+            backend = load_backend(backend_path)
+            user = backend.get_user(user_id) or AnonymousUser()
+        else:
+            user = AnonymousUser()
     except KeyError:
         user = AnonymousUser()
     return user

tests/regressiontests/auth_backends/tests.py

@@ -3 +3 @@
 except NameError:
     from sets import Set as set     # Python 2.3 fallback
 
+from unittest import TestCase
+from django.contrib import auth
+from django.http import HttpRequest
+from django.contrib.auth.models import User, AnonymousUser
+from django.conf import settings
+
+class StubBackend:
+    TestUser_1 = User()
+    def get_user(self, id):
+        if id == 1: 
+            return StubBackend.TestUser_1
+    
+class GetUserTests(TestCase):
+    def load_backend(self, backend_path):
+        if backend_path == "some.backend":
+            return StubBackend()
+
+    def setUp(self):
+        self.old_load_backend = auth.load_backend  
+        self.old_auth_backends = settings.AUTHENTICATION_BACKENDS  
+
+        auth.load_backend = self.load_backend 
+        settings.AUTHENTICATION_BACKENDS = ("some.backend",) 
+
+        self.request = HttpRequest()
+        self.request.session = {}
+
+    def set_up_session(self, uid, backend):
+        self.request.session[auth.SESSION_KEY] = uid
+        self.request.session[auth.BACKEND_SESSION_KEY] = backend
+
+    def tearDown(self):
+        auth.load_backend = self.old_load_backend
+        settings.AUTHENTICATION_BACKENDS = self.old_auth_backends
+
+    def test_user_loaded_with_backend(self):
+        self.set_up_session(uid=1, backend="some.backend")
+        user = auth.get_user(self.request)
+        self.assertEquals(user, StubBackend.TestUser_1)
+
+    def test_user_loaded_with_backend_invalid_uid(self):
+        self.set_up_session(uid='INVALID', backend="some.backend")
+        user = auth.get_user(self.request)
+        self.assert_(isinstance(user,AnonymousUser))
+
+    def test_user_loaded_with_invalid_backend(self):
+        self.set_up_session(uid=1, backend="invalid.backend")
+        user = auth.get_user(self.request)
+        self.assert_(isinstance(user,AnonymousUser))
+
 __test__ = {'API_TESTS': """
 >>> from django.contrib.auth.models import User, Group, Permission, AnonymousUser
 >>> from django.contrib.contenttypes.models import ContentType
@@ -75 +125 @@
 False
 >>> user.has_perms(['auth.test2', 'auth.test3'])
 False
-"""}
+""",
+'GetUserTests': GetUserTests}
+
+