Ticket #11303: show_hidden_initial_boolean.diff

django/forms/widgets.py

@@ -386 +386 @@
 
     def _has_changed(self, initial, data):
         # Sometimes data or initial could be None or u'' which should be the
-        # same thing as False.
+        # same thing as False. If show_hidden_initial is true on the field then 
+        # the initial value will come through as the string 'False' which when
+        # converted to boolean returns True 
+        if initial == 'False':
+            initial = False
         return bool(initial) != bool(data)
 
 class Select(Widget):

tests/regressiontests/forms/forms.py

@@ -1795 +1795 @@
 >>> form.is_valid()
 True
 
+
+# BooleanFields with show_hidden_initial report changed when they haven't #######################
+
+>>> class SubscriberForm(Form):
+...     name = CharField(show_hidden_initial=True)
+...     new_subscriber = BooleanField(show_hidden_initial=True, required=False)
+... 
+>>> def my_function(method, post_data):
+...     if method == 'POST':
+...         form = SubscriberForm(post_data)
+...     else:
+...         form = SubscriberForm()
+...     if form.is_valid():
+...         return form.changed_data
+...     t = Template('<form action="" method="post">\n<table>\n{{ form }}\n</table>\n<input type="submit" />\n</form>')
+...     return t.render(Context({'form': form}))
+... 
+>>> print my_function('POST', {'name': 'James', 'initial-name': 'James', 'new_subscriber': False, 'initial-new_subscriber': 'False'})
+[]
+
 # Extracting hidden and visible fields ######################################
 
 >>> class SongForm(Form):