Ticket #11195: 11195_admin-changelist-cell-class-fieldname.1.diff

django/contrib/admin/templatetags/admin_list.py

@@ -137 +137 @@
     first = True
     pk = cl.lookup_opts.pk.attname
     for field_name in cl.list_display:
-        row_class = ''
+        row_classes = ['fieldname_%s' % field_name]
         try:
             f = cl.lookup_opts.get_field(field_name)
         except models.FieldDoesNotExist:
@@ -193 +193 @@
                         result_repr = capfirst(dateformat.format(field_val, date_format))
                 else:
                     result_repr = EMPTY_CHANGELIST_VALUE
-                row_class = ' class="nowrap"'
+                row_classes.append('nowrap')
             # Booleans are special: We use images.
             elif isinstance(f, models.BooleanField) or isinstance(f, models.NullBooleanField):
                 result_repr = _boolean_icon(field_val)
@@ -211 +211 @@
                 result_repr = escape(field_val)
         if force_unicode(result_repr) == '':
             result_repr = mark_safe(' ')
+        row_class = ' class="%s"' % ' '.join(row_classes)
         # If list_display_links not defined, add the link tag to the first field
         if (first and not cl.list_display_links) or field_name in cl.list_display_links:
             table_tag = {True:'th', False:'td'}[first]

tests/regressiontests/admin_views/tests.py

@@ -577 +577 @@
         self.failUnlessEqual(logged.object_id, u'1')
         self.client.get('/test_admin/admin/logout/')
 
+class AdminChangeListFieldNameClassAttrTest(TestCase):
+    fixtures = ['admin-views-users.xml']
+
+    def setUp(self):
+        self.client.login(username='super', password='secret')
+
+    def tearDown(self):
+        self.client.logout()
+
+    def test_class_attributes(self):
+        "Cells of the change list table should contain the field name in their class attribute"
+        Podcast.objects.create(name="This Week in Django",
+            release_date=datetime.date.today())
+        response = self.client.get('/test_admin/admin/admin_views/podcast/')
+        self.assertContains(
+            response, '<td class="fieldname_action_checkbox">')
+        self.assertContains(
+            response, '<th class="fieldname_name">')
+        self.assertContains(
+            response, '<td class="fieldname_release_date nowrap">')
+
 class AdminViewStringPrimaryKeyTest(TestCase):
     fixtures = ['admin-views-users.xml', 'string-primary-key.xml']
 
@@ -601 +622 @@
     def test_changelist_to_changeform_link(self):
         "The link from the changelist referring to the changeform of the object should be quoted"
         response = self.client.get('/test_admin/admin/admin_views/modelwithstringprimarykey/')
-        should_contain = """<th><a href="%s/">%s</a></th></tr>""" % (quote(self.pk), escape(self.pk))
+        should_contain = """<th class="fieldname___str__"><a href="%s/">%s</a></th></tr>""" % (quote(self.pk), escape(self.pk))
         self.assertContains(response, should_contain)
 
     def test_recentactions_link(self):