Ticket #10762: 10762_with_tests.patch

django/middleware/gzip.py

@@ -12 +12 @@
     on the Accept-Encoding header.
     """
     def process_response(self, request, response):
-        # It's not worth compressing non-OK or really short responses.
-        if response.status_code != 200 or len(response.content) < 200:
+        # It's not worth compressing really short responses.
+        if len(response.content) < 200:
             return response
 
         patch_vary_headers(response, ('Accept-Encoding',))

tests/regressiontests/middleware/tests.py

@@ -9 +9 @@
 from django.middleware.clickjacking import XFrameOptionsMiddleware
 from django.middleware.common import CommonMiddleware
 from django.middleware.http import ConditionalGetMiddleware
+from django.middleware.gzip import GZipMiddleware
 from django.test import TestCase
 
 
@@ -495 +496 @@
         r = OtherXFrameOptionsMiddleware().process_response(HttpRequest(),
                                                        HttpResponse())
         self.assertEqual(r['X-Frame-Options'], 'DENY')
+
+class GZipMiddlewareTest(TestCase):
+    def _get_processed_response(self, content, status):
+        request = HttpRequest()
+        request.META = {'HTTP_ACCEPT_ENCODING': 'gzip'}
+        response = HttpResponse(content, status=status)
+        return GZipMiddleware().process_response(request, response)
+
+    def test_short_ok_should_not_be_gzipped(self):
+        r = self._get_processed_response('hello world', status=200)
+
+        self.assertNotIn('Content-Encoding', r)
+
+    def test_long_ok_should_be_gzipped(self):
+        r = self._get_processed_response('hello world'*20, status=200)
+
+        self.assertEqual(r['Content-Encoding'], 'gzip')
+
+    def test_long_created_should_be_gzipped(self):
+        r = self._get_processed_response('hello world'*20, status=201)
+
+        self.assertEqual(r['Content-Encoding'], 'gzip')