Ticket #10497: storage_times.3.diff

django/core/files/storage.py

@@ -2 +2 @@
 import errno
 import urlparse
 import itertools
+import datetime
 
 from django.conf import settings
 from django.core.exceptions import ImproperlyConfigured, SuspiciousOperation
@@ -120 +121 @@
         """
         raise NotImplementedError()
 
+    def accessed_time(self, name):
+        """
+        Returns the last accessed time (as Datetime object) for a given name.
+        If the subclass don't support accessed times, a NotImplementedError 
+        should be raised. (just dont overwrite this method in the subclass)
+        """
+        raise NotImplementedError("This backend doesn't support accessed time.")
+
+    def created_time(self, name):
+        """
+        Returns the creation time (as Datetime object) for a given name.
+        If the subclass don't support creation times, a NotImplementedError
+        should be raised. (just dont overwrite this method in the subclass)
+        """
+        raise NotImplementedError("This backend doesn't support created time.")
+
+    def modified_time(self, name):
+        """
+        Returns the last modified time (as Datetime object) for a given name.
+        If the subclass don't support modified times, a NotImplementedError
+        should be raised. (just dont overwrite this method in the subclass)
+        """
+        raise NotImplementedError("This backend doesn't support modified time.")
+
 class FileSystemStorage(Storage):
     """
     Standard filesystem storage
@@ -220 +245 @@
             raise ValueError("This file is not accessible via a URL.")
         return urlparse.urljoin(self.base_url, name).replace('\\', '/')
 
+    def accessed_time(self, name):
+        return datetime.datetime.fromtimestamp(
+            os.path.getatime(self.path(name)))
+
+    def created_time(self, name):
+        return datetime.datetime.fromtimestamp(
+            os.path.getctime(self.path(name)))
+
+    def modified_time(self, name):
+        return datetime.datetime.fromtimestamp(
+            os.path.getmtime(self.path(name)))
+
 def get_storage_class(import_path=None):
     if import_path is None:
         import_path = settings.DEFAULT_FILE_STORAGE

docs/ref/files/storage.txt

@@ -13 +13 @@
 ``open()``. For storage systems that aren't accessible from the local
 filesystem, this will raise ``NotImplementedError`` instead.
 
+``Storage.accessed_time(name)``
+~~~~~~~~~~~~~~~~~~~~~~
+
+Returns a ``datetime`` object containing the last accessed time of the file.
+For storage systems that aren't able to return the last accessed time, this
+will raise ``NotImplementedError`` instead.
+
+``Storage.created_time(name)``
+~~~~~~~~~~~~~~~~~~~~~~
+
+Returns a ``datetime`` object containing the creation time of the file.
+For storage systems that aren't able to return the creation time, this
+will raise ``NotImplementedError`` instead.
+
+``Storage.modified_time(name)``
+~~~~~~~~~~~~~~~~~~~~~~
+
+Returns a ``datetime`` object containing the last modified time. For storage
+systems that aren't able to return the last modified time, this will raise
+``NotImplementedError`` instead.
+
 ``Storage.size(name)``
 ~~~~~~~~~~~~~~~~~~~~~~
 

tests/regressiontests/file_storage/tests.py

@@ -6 +6 @@
 import time
 import unittest
 from cStringIO import StringIO
+from datetime import datetime, timedelta
 from django.conf import settings
 from django.core.exceptions import SuspiciousOperation
 from django.core.files.base import ContentFile, File
@@ -81 +82 @@
 
 class FileStorageTests(unittest.TestCase):
     storage_class = FileSystemStorage
-    
+
     def setUp(self):
         self.temp_dir = tempfile.mktemp()
         os.makedirs(self.temp_dir)
         self.storage = self.storage_class(location=self.temp_dir,
             base_url='/test_media_url/')
-    
+
     def tearDown(self):
         shutil.rmtree(self.temp_dir)
-        
+
     def test_file_access_options(self):
         """
         Standard file access options are available, and work as expected.
@@ -104 +105 @@
         f = self.storage.open('storage_test', 'r')
         self.assertEqual(f.read(), 'storage contents')
         f.close()
-        
+
         self.storage.delete('storage_test')
         self.failIf(self.storage.exists('storage_test'))
 
+    def test_file_accessed_time(self):
+        """
+        File storage returns a Datetime object for the last accessed time of
+        a file.
+        """
+        self.failIf(self.storage.exists('test.file'))
+
+        f = File(open(__file__, 'rb'))
+        f_name = self.storage.save('test.file', f)
+
+        self.assertEqual(
+            self.storage.accessed_time(f_name),
+            datetime.fromtimestamp(os.path.getatime(self.storage.path(f_name)))
+        )
+
+        self.assertTrue(
+            datetime.now() - self.storage.accessed_time(f_name) < timedelta(seconds=2)
+        )
+
+        self.storage.delete(f_name)
+
+    def test_file_created_time(self):
+        """
+        File storage returns a Datetime object for the creation time of
+        a file.
+        """
+        self.failIf(self.storage.exists('test.file'))
+
+        f = File(open(__file__, 'rb'))
+        f_name = self.storage.save('test.file', f)
+
+        self.assertEqual(
+            self.storage.created_time(f_name),
+            datetime.fromtimestamp(os.path.getctime(self.storage.path(f_name)))
+        )
+
+        self.assertTrue(
+            datetime.now() - self.storage.created_time(f_name) < timedelta(seconds=2)
+        )
+
+        self.storage.delete(f_name)
+
+    def test_file_modified_time(self):
+        """
+        File storage returns a Datetime object for the last modified time of
+        a file.
+        """
+        self.failIf(self.storage.exists('test.file'))
+
+        f = File(open(__file__, 'rb'))
+        f_name = self.storage.save('test.file', f)
+
+        self.assertEqual(
+            self.storage.modified_time(f_name),
+            datetime.fromtimestamp(os.path.getmtime(self.storage.path(f_name)))
+        )
+
+        self.assertTrue(
+            datetime.now() - self.storage.modified_time(f_name) < timedelta(seconds=2)
+        )
+
+        self.storage.delete(f_name)
+
     def test_file_save_without_name(self):
         """
         File storage extracts the filename from the content object if no
@@ -215 +279 @@
 
 class CustomStorageTests(FileStorageTests):
     storage_class = CustomStorage
-    
+
     def test_custom_get_available_name(self):
         first = self.storage.save('custom_storage', ContentFile('custom contents'))
         self.assertEqual(first, 'custom_storage')