Wrap help_text in "<span class="helptext"></span>", like errors in "<ul class="errorlist"></ul>" in HTML output

[ErikW]

form.as_p() and form.as_ul() should both either have a div (with class="help"), span, or br around the help_text. form.as_table() already has a br tag before the helptext. So this should be added to improve consistency. This will really aid in styling the form with CSS!

[Malcolm Tredinnick]

This could well be wontfix, since you can easily write your own output methods to do whatever you like in forms. We can make a decision after 1.0.

[Gergely Kontra]

Is it the right time for a design decision on this ticket?

Note, that error messages has custom ul class, so why not have it for help_text?
And the implementation is fairly trivial.

What is against accepting it? (well, I can write arbitrary output method, but why cannot be the default ones perfect?)

[mrts]

Pushing to accepted as per jacob on Version1.1Features:

• Wrap help_text in "<span class="helptext"></span>", like errors in "<ul class="errorlist"></ul>" in HTML output. (needs ticket)

[mrts]

That should of course have been Version1.1Features.

[mrts]

Add tests and fix as_p()

[mrts]

Not sure if documentation is needed though.

[(none)]

Milestone post-1.0 deleted

[mrts]

Tentatively pushing to 1.1 beta, assuming that this was just missed (it seems that Jacob agrees it's needed). As it's a feature, it should be either committed before 1.1 beta or deferred to 1.2.

[mrts]

Update to r10116

[Jacob]

Markup changes don't count as features; this can wait and go in with the other bug fixes.

[coulix]

The path always add help_text even when no help_text is set in the form

[André Cruz]

Is there a reason for this not being included in trunk?

[Randy Barlow]

Here's an updated patch.

[Randy Barlow]

Hey Karen, this one's ready to go in!

[James Bennett]

1.2 is feature-frozen, moving this feature request off the milestone.

[Gergely Kontra]

Definitely not happy. Simple bug, simple patch, more than one year old.

[James Bennett]

Replying to pihentagy:

Definitely not happy. Simple bug, simple patch, more than one year old.

Like it or not, this is a feature request, and the process for feature requests getting into new releases is documented. The biggest factor for a small request is that someone motivated -- perhaps you, if you feel strongly about this ticket -- needs to bring it up during the feature-development phase of a release cycle and make sure there's some discussion about it and a decision as to whether it's worth adding. If no-one does that (and no-one did for the 1.2 release cycle), it's more or less inevitable that the request will simply be punted until someone does. And since 1.2 is feature-frozen there's no way to do that for 1.2 now; if you'd like to see this make it into Django, then make a note of it and pop onto the django-dev list when feature discussion for 1.3 opens up in a month or so.

[holms]

oh please God... why this must hang for 2 years =( it's really REALLY inconvinient... is it takes too much time to include this fix into release? I need it die hard!

[Luke Plant]

(In [13519]) Fixed #8426 - added 'helptext' CSS class to help text in forms to aid in styling

Thanks to erikcw for report, mrts and rpbarlow for patch

[Matt McClanahan]

[13519] appears to be just the tests, not the forms/forms.py fix.

[Luke Plant]

(In [13522]) Fixed #8426 - 'helptext' CSS class - hopefully for real this time.

This file was missing from [13519]

Thanks to mattmcc for the catch.