Django

Code

Ticket #8276 (closed: fixed)

Opened 4 months ago

Last modified 3 months ago

Change fields' names in django.contrib.localflavor.pl.forms

Reported by: Piotr Lewandowski <django@icomputing.pl> Assigned to: nobody
Milestone: 1.0 Component: django.contrib.localflavor
Version: SVN Keywords:
Cc: ubanus@users.sf.net Triage Stage: Accepted
Has patch: 1 Needs documentation: 0
Needs tests: 0 Patch needs improvement: 0

Description

I would like to propose backward incompatible change django.contrib.localflavor.pl.forms:

Some classes present in django.contrib.localflavor.pl.forms are named in a werid way - they are neither short and useful, nor offical translations of corresponding numbers.

Old nameNew name
PLNationalIdentificationNumberFieldPLPESELField
PLTaxNumberFieldPLNIPField
PLNationalBusinessRegisterFieldPLREGONField
PLVoivodeshipSelectPLProvinceSelect
PLAdministrativeUnitSelectPLCountiesSelect

Not only Polish people in everyday language use those acronyms, but even Polish officials refer to those numbers as PESEL, REGON and NIP:

I'm willing to prepare the patch if those changes are accepted.

Attachments

polish_forms_r8521.diff (0.9 kB) - added by msaelices on 08/24/08 16:31:44.
A patch that fixes typo error
polish_form_r8522.diff (20.9 kB) - added by Piotr Lewandowski <django@icomputing.pl> on 08/24/08 17:09:54.
Previous patch does not include tests

Change History

08/13/08 12:28:26 changed by mtredinnick

  • needs_better_patch changed.
  • needs_docs changed.
  • stage changed from Unreviewed to Accepted.
  • needs_tests changed.
  • milestone set to 1.0 beta.

Using the "correct" names sounds right and, failing any other indication, the common usage is correct. So this seems reasonable. I'll get it in before the beta.

08/13/08 17:32:49 changed by Piotr Lewandowski <django@icomputing.pl>

Malcolm, can you also take a look at ticket #8197? Are there any chances to get that in before the beta?

PLCountiesSelect (aka PLAdministrativeUnitSelect) is using outdated counties list - I don't know whether it's worth filling separate ticket.

In the long run, fields like PLProvinceSelect, PLCountiesSelect and not-yet-existing PLCommunesSelect and PLCitiesSelect could use data from pl_regions.py introduced in #8197 so they'd be up-to-date. I may prepare a path combining this feature and issues mentioned in #8197 and #8276.

08/13/08 23:14:18 changed by mtredinnick

#8197 is unrelated to this ticket. Adding new stuff like that can wait, since there are design questions there.

08/13/08 23:29:03 changed by mtredinnick

  • status changed from new to closed.
  • resolution set to fixed.

(In [8345]) Fixed #8276 -- Changed the names of a few Polish localflavor classes to match their common names/acronyms, similar to other localflavors.

Backwards incompatible if you're using these classes.

08/24/08 04:07:56 changed by Piotr Lewandowski <django@icomputing.pl>

  • status changed from closed to reopened.
  • resolution deleted.

My mistake - PLCountiesSelect should be rather named PLCountySelect - to be coherent with ro and uk localflavors.

08/24/08 16:31:44 changed by msaelices

  • attachment polish_forms_r8521.diff added.

A patch that fixes typo error

08/24/08 16:32:01 changed by msaelices

  • has_patch set to 1.

08/24/08 17:09:54 changed by Piotr Lewandowski <django@icomputing.pl>

  • attachment polish_form_r8522.diff added.

Previous patch does not include tests

08/25/08 00:17:35 changed by mtredinnick

  • milestone changed from 1.0 beta to 1.0.

08/26/08 12:59:13 changed by Jakub Wilk <ubanus@users.sf.net>

  • cc set to ubanus@users.sf.net.

08/27/08 18:05:26 changed by jacob

  • status changed from reopened to closed.
  • resolution set to fixed.

(In [8643]) Fixed #8276: corrected another couple of names in localflavor.pl.forms. Patch by Piotr Lewandowski.

Add/Change #8276 (Change fields' names in django.contrib.localflavor.pl.forms)




Change Properties
Action