Opened 17 years ago

Closed 17 years ago

Last modified 17 years ago

#8275 closed (fixed)

Unused and unnecessary imports in auth views

Reported by: Julien Phalip Owned by: nobody
Component: contrib.auth Version: dev
Severity: Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

Attached patch removes those.

Attachments (1)

8275.unused_imports.diff​ (2.4 KB ) - added by Julien Phalip 17 years ago.

Download all attachments as: .zip

Change History (9)

by Julien Phalip, 17 years ago

Attachment: 8275.unused_imports.diff​ added

comment:1 by anonymous, 17 years ago

Below each of the lines where you removed the settings import is a line that uses the settings.

comment:2 by Julien Phalip, 17 years ago

Yes, but settings is already imported at the top of the file, so all the imports inside the views are unnecessary.

comment:3 by Malcolm Tredinnick, 17 years ago

milestone: → 1.0
Triage Stage: Unreviewed → Accepted

comment:4 by James Bennett, 17 years ago

milestone: 1.0 → 1.0 maybe

Since this is cosmetic, I'm dropping it back to "maybe".

comment:5 by Jacob, 17 years ago

milestone: 1.0 maybe → post-1.0

Purely cosmetic - pushing post-1.0.

comment:6 by (none), 17 years ago

milestone: post-1.0

Milestone post-1.0 deleted

comment:7 by russ, 17 years ago

Resolution: → fixed
Status: new → closed

The latest SVN version doesn't have the extra import statements. Fixed by r8386.

comment:8 by russ, 17 years ago

Oops, sorry -- I ought to have read the rules carefully, first. I should have set this to worksforme, since I'm certainly no core developer. My mistake!

Note: See TracTickets for help on using tickets.
Back to Top