Django

Code

Ticket #8206 (closed: fixed)

Opened 4 months ago

Last modified 4 months ago

Remove models.base.Model.validate(), manipulator field functions, validator lists

Reported by: mtredinnick Assigned to: gwilson
Milestone: 1.0 beta Component: Core framework
Version: SVN Keywords:
Cc: Triage Stage: Accepted
Has patch: 0 Needs documentation: 0
Needs tests: 0 Patch needs improvement: 0

Description

With the model-aware validation being pushed to after 1.0, we should ensure nobody uses code that is intentionally in a broken or unsupported state. This means

  • Removing django.db.models.base.Model.validate(), since it's always been incomplete and not to be used. But still people try using it. It's not part of the public API at the moment.
  • Removing code in django.db.models.fields that is only to support manipulators. They are only oldforms-admin related.
  • Removing validator lists from field classes, since they're again only oldforms-admin related.

This probably goes after removing oldforms (#7742) to get the ordering right for people still using oldforms + manipulators.

Attachments

Change History

08/10/08 16:51:07 changed by gwilson

  • status changed from new to assigned.
  • needs_better_patch changed.
  • needs_tests changed.
  • owner changed from nobody to gwilson.
  • needs_docs changed.
  • stage changed from Unreviewed to Accepted.

(in reply to: ↑ description ) 08/10/08 16:57:48 changed by gwilson

Replying to mtredinnick:

* Removing code in django.db.models.fields that is only to support manipulators. They are only oldforms-admin related. * Removing validator lists from field classes, since they're again only oldforms-admin related.

I'm rolling both of these into #7742, as they are oldforms-related but will need to stick around until the rest of Django is oldforms-free.

08/14/08 10:37:44 changed by gwilson

  • status changed from assigned to closed.
  • resolution set to fixed.

(In [8348]) Fixed #8206 -- Removed validate methods of Model and Model fields. They are are unsupported for 1.0 and will be replaced with more complete model validation (refs #6845).

Add/Change #8206 (Remove models.base.Model.validate(), manipulator field functions, validator lists)




Change Properties
Action