remove oldforms

Since the comment system will continue to use oldforms in 1.0, shouldn't this be a post-1.0?

mir: Comments is one of the special cases. Thejaswi Puthraya is working on comments as part of the GSOC; unless I've missed a memo, this is still on the cards to happen.

oldforms is still being used in the following locations:

• django.contrib.admin.views.template - template_validator view and TemplateValidator manipulator class.
• django.contrib.comments.views.comments - multiple forms.
• In the methods prepare_field_objs_and_params and get_manipulator_field_objs in the following files:
  • django.contrib.contenttypes.generic - GenericRelation model field subclass.
  • django.db.models.__init__
  • django.db.models.related
  • django.db.models.manipulators

Also, while not using the oldforms package directly, the following model field methods (noted by Russell on #7830) are related to oldforms:

• get_manipulator_field_names()
• get_manipulator_fields()
• get_manipulator_new_data()
• flatten_data()
• get_choices()
• get_choices_default()

(In [8292]) Refs #7742 -- newforms-admin does not use oldforms validator_list argument, made a custom FlatPageForm to check the entered URL.

(In [8293]) Refs #7742 -- Removed unused validator_list argument (this is already being checked by the UserCreationForm).

(In [8295]) Refs #7742 -- Removed oldforms bits from contrib.gis app.

I'm attaching a patch to see what this is looking like. contrib.comments is still blocking this, and I haven't yet looked into whether get_choices and get_default_choices can be removed or not.

The remaining portions of this are no longer 1.0-beta. Changing the milestone (ideally to 1.0-ASAP :-) ).

patch updated for docs and comments merge

Here's my commit message draft:

Removed oldforms and oldforms-related code:

• Removed Manipulator, AutomaticManipulator, and related classes.
• Removed oldforms specific bits from model fields:
  • Removed validator_list argument in constructors.
  • Removed the methods:
    • get_manipulator_field_names
    • get_manipulator_field_objs
    • get_manipulator_fields
    • get_manipulator_new_data
    • prepare_field_objs_and_params
    • get_follow
  • Renamed flatten_data method to get_string_value for better alignment with its use by the serialization framework, which was the only remaining code using flatten_data.
• Removed oldforms methods from django.db.models.Options class: get_followed_related_objects, get_data_holders, get_follow, and has_field_type.
• Serialization framework
  • Serializer.get_string_value now calls the model fields' renamed get_string_value methods.
  • Removed a special-casing of models.DateTimeField in core.serializers.base.Serializer.get_string_value that's handled by django.db.models.fields.DateTimeField.get_string_value.
• Introduced a SlugField? form field for validation (refs #8040).
• Removed an oldforms-style model creation hack (refs #2160).

I don't see the reason why we should still accept core. It is no longer used in the admin.

Replying to brosner:

I don't see the reason why we should still accept core. It is no longer used in the admin.

Yes, I was wondering why it was still documented, even in the new docs:

http://docs.djangoproject.com/en/dev/ref/models/fields/#common-model-field-options

It needs to be made go away, I think. It's now both confusing and useless?

Indeed - Gary, you can add removing core and its documentation to this patch; from there I don't see anything else that you need to wait on to commit this.

I have updated the patch to remove core and the various admin options that needed to get removed. Also I noticed that there was revert of [8477]. Gary, the second to last item in your commit message draft was fixed.

Hrm, whoops should git svn rebase a bit more often. Let me attach a fixed patch. I noticed a couple more things.

Here is a revised commit message draft that can be used.

Removed oldforms and oldforms-related code:

• Removed Manipulator, AutomaticManipulator, and related classes.
• Removed oldforms specific bits from model fields:
  • Removed validator_list argument in constructors.
  • Removed the methods:
    • get_manipulator_field_names
    • get_manipulator_field_objs
    • get_manipulator_fields
    • get_manipulator_new_data
    • prepare_field_objs_and_params
    • get_follow
  • Renamed flatten_data method to get_string_value for better alignment with its use by the serialization framework, which was the only remaining code using flatten_data.
• Removed oldforms methods from django.db.models.Options class: get_followed_related_objects, get_data_holders, get_follow, and has_field_type.
• Removed oldforms-admin specific options: core, num_in_admin, min_num_in_admin, max_num_in_admin, num_extra_on_change, edit_inline
• Serialization framework
  • Serializer.get_string_value now calls the model fields' renamed get_string_value methods.
  • Removed a special-casing of models.DateTimeField in core.serializers.base.Serializer.get_string_value that's handled by django.db.models.fields.DateTimeField.get_string_value.
• Removed an oldforms-style model creation hack (refs #2160).

fixed in [8616].