Opened 17 years ago
Closed 14 years ago
#8052 closed Bug (fixed)
Password Change Forms overrides userlinks
| Reported by: | Django Trac | Owned by: | |
|---|---|---|---|
| Component: | contrib.admin | Version: | dev |
| Severity: | Normal | Keywords: | |
| Cc: | Triage Stage: | Accepted | |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | yes |
| Easy pickings: | no | UI/UX: | no |
Description
Password change form explicitly sets
{% block userlinks %}
which is preventing custom templates from showing through for that portion of the page.
ie: I have a template called admin/base_site.html which includes the {% block userlinks %} but does not have the documentation link. However on the change password form, the old format (with the Documentation hyperlink), is showing up instead.
A quick flick through the admin templates shows this may be redundant and removing the line fixes it.
SVN 8151
Attachments (1)
Change History (8)
by , 17 years ago
| Attachment: | password_change_8052.diff added |
|---|
comment:1 by , 17 years ago
| Component: | Uncategorized → Admin interface |
|---|---|
| Has patch: | set |
| Owner: | changed from to |
| Status: | new → assigned |
comment:2 by , 17 years ago
| Triage Stage: | Unreviewed → Accepted |
|---|
comment:3 by , 17 years ago
| Owner: | removed |
|---|---|
| Status: | assigned → new |
comment:4 by , 17 years ago
| Summary: | Password Change Form overrides userlinks → Password Change Forms overrides userlinks |
|---|
comment:5 by , 17 years ago
| Patch needs improvement: | set |
|---|
The problem with removing the {% block userlinks %} from password_change_form.html and password_change_done.html is that the "change password" and "logout" links inherited from the default admin/base_site.html are wrong on these pages. #8984 covers fixing the "Documentation" link for these pages, and #8933 proposes making these templates overridable. I think once either of those is fixed, the reason for this ticket goes away, right?
comment:6 by , 15 years ago
| Severity: | → Normal |
|---|---|
| Type: | → Bug |
comment:7 by , 14 years ago
| Easy pickings: | unset |
|---|---|
| Resolution: | → fixed |
| Status: | new → closed |
| UI/UX: | unset |
Same problem in password_change_done.html