Opened 16 years ago
Closed 15 years ago
#8933 closed (fixed)
Make more admin templates overridable
Reported by: | Jannis Leidel | Owned by: | Jannis Leidel |
---|---|---|---|
Component: | contrib.admin | Version: | dev |
Severity: | Keywords: | ||
Cc: | Triage Stage: | Accepted | |
Has patch: | yes | Needs documentation: | no |
Needs tests: | yes | Patch needs improvement: | no |
Easy pickings: | no | UI/UX: | no |
Description
The following methods are missing options to override their templates:
django.contrib.admin.sites.AdminSite
: logout, password_change and password_change_donedjango.contrib.auth.admin.UserAdmin
: add_view and user_change_password
Attachments (2)
Change History (14)
by , 16 years ago
Attachment: | ticket8933-r8979.diff added |
---|
comment:1 by , 16 years ago
Has patch: | set |
---|---|
milestone: | post-1.0 |
comment:2 by , 16 years ago
Just to be a bit more specific why this is useful:
I use the new admin in django-mobileadmin to provide a special admin interface for mobile devices by loading admin templates depending on the user agent of the browser. The templates used in most of the admin views can already be overridden, those five are missing.
comment:3 by , 16 years ago
The commit is also at http://github.com/jezdez/django/commit/6f04f3ac752a4802a7ce5ac0c5f9f22b974ccb25
comment:4 by , 16 years ago
Sorry, the commit is here http://github.com/jezdez/django/commit/929242d1954d5510b385334f63c0cbe18a25aeef
comment:5 by , 16 years ago
Triage Stage: | Unreviewed → Accepted |
---|
comment:6 by , 16 years ago
This must have slipped under my radar before 1.0. It would have been best to have gotten it in before 1.0, but the timing was a bit off. This looks good heading towards 1.1 though.
comment:7 by , 16 years ago
Owner: | changed from | to
---|
comment:8 by , 16 years ago
Status: | new → assigned |
---|
comment:9 by , 16 years ago
If I was to nitpick, I'd say that the new 'registration' templates shouldn't add the keyword arg unless they need to (otherwise you're hard-coding a default in two places)
by , 16 years ago
Attachment: | ticket8933-r8979.2.diff added |
---|
small fix to appease SmilyChris' niticking
comment:10 by , 16 years ago
Needs tests: | set |
---|
This ticket is going to need some tests. There are tests located in tests/regressiontests/admin_views/tests.py
for AdminSite
templates. The UserAdmin
templates are new so similar tests will likely need to be added in the auth app. Ultimately this patch needs documentation as well. However, I am going to tackle that as a part of getting more complete admin docs of the options available. Most of what is missing is template related anyways.
comment:11 by , 15 years ago
Owner: | changed from | to
---|---|
Status: | assigned → new |
Version: | 1.0 → SVN |
comment:12 by , 15 years ago
Resolution: | → fixed |
---|---|
Status: | new → closed |
fix to make more templates overridable