FileFields have wrong url in admin under Windows, when using upload_to path

[edgars.jekabsons@…]

Right now (revision 7612) AdminFileWidget is implemented this way:

if value:
    output.append('%s <a target="_blank" href="%s%s">%s</a> <br />%s ' % \
                (_('Currently:'), settings.MEDIA_URL, value, value, _('Change:')))

The value in database contains \ as a path separator. It is shown as a url instead of needed / separator for urls. Works as is under Unix, but clearly not on Windows.

Model get_<field>_url() method gives the url with correct path separator. Perhaps it should be used in the link instead of value.

[rudyryk <alexey.rudy@…>]

As I know, it's better to define all paths with '/' not depending on platform - it is valid. I do so and have no such problem as you described.

[edgarsj]

Django creates the file path with '\' itself in database after uploading the file via admin.

[edgarsj]

I guess milestone 1.0 means accepted.

[Julien Phalip]

I fixed it on Windows using 'url.pathname2url()'. See patch.
Could someone test it on other platforms?

[Julien Phalip]

Patch and tests

[Julien Phalip]

Oops, that was me above...

[Marty Alchin]

I'm not sure the proposed patch is the best approach for this, but I'll take a look at this as part of #5361, since most of the affected code is changing as part of that anyway.

[jvtm]

IMHO, better approach is to always use / as path separator. This guarantees that the filesystem stuff works on different platforms (just getting the value from database and using it for something).

Fixed the same problem with fieldname = fieldname.replace(os.path.sep, "/") on the application side.

[Marty Alchin]

The updated patch on #5361 addresses this issue, explicitly converting all slashes to forward slashes when saving to the database, and doing the same when displaying the URL, just in case older data is stored that way.

[Julien Phalip]

Cool, I agree that your approach of saving the paths with forward slashes in database is best here. One concern though, will that also work with pre-existing records, which have already been saved with backward slashes?

[Marty Alchin]

That alone won't solve the problem with existing data, but the conversion to forward slashes now happens when retrieving the URL, so it should all work out quite well. Feel free to give it a shot if you have some time, if you'd like to verify.

[Marty Alchin]

Correction. The existing patch on #5361 does not yet completely fix this issue. The next patch will have an update to AdminFileWidget to take care of this properly.

[Jacob]

(In [8244]) File storage refactoring, adding far more flexibility to Django's file handling. The new files.txt document has details of the new features.

This is a backwards-incompatible change; consult BackwardsIncompatibleChanges for details.

Fixes #3567, #3621, #4345, #5361, #5655, #7415.

Many thanks to Marty Alchin who did the vast majority of this work.

[Jacob]

Milestone 1.0 beta deleted