Django

Code

Ticket #5655 (closed: fixed)

Opened 2 years ago

Last modified 2 years ago

FileField's _save_FIELD_file method evaluates the directory once for creating the directory, then again for creating the file

Reported by: SmileyChris Assigned to: Gulopine
Milestone: 1.0 beta Component: Database layer (models, ORM)
Version: SVN Keywords: fs-rf-fixed
Cc: Triage Stage: Accepted
Has patch: 1 Needs documentation: 0
Needs tests: 0 Patch needs improvement: 0

Description

I'm sure there's a more succinct way to say that...

Anyway, the directory should only be calculated once, to avoid potentially creating one time-based upload directory the then attempting to upload to a different directory.

Attachments

5655.patch (1.6 kB) - added by SmileyChris on 10/01/07 20:22:34.

Change History

10/01/07 20:22:34 changed by SmileyChris

  • attachment 5655.patch added.

12/11/07 12:01:08 changed by Gulopine

  • keywords set to fs-rf.
  • needs_better_patch changed.
  • needs_tests changed.
  • needs_docs changed.

12/16/07 15:59:47 changed by Gulopine

  • keywords changed from fs-rf to fs-rf-fixed.

02/28/08 11:19:47 changed by jacob

  • stage changed from Unreviewed to Accepted.

06/16/08 13:30:17 changed by Gulopine

  • milestone set to 1.0 beta.

07/31/08 08:02:29 changed by Gulopine

  • owner changed from nobody to Gulopine.
  • status changed from new to assigned.

08/08/08 15:59:02 changed by jacob

  • status changed from assigned to closed.
  • resolution set to fixed.

(In [8244]) File storage refactoring, adding far more flexibility to Django's file handling. The new files.txt document has details of the new features.

This is a backwards-incompatible change; consult BackwardsIncompatibleChanges for details.

Fixes #3567, #3621, #4345, #5361, #5655, #7415.

Many thanks to Marty Alchin who did the vast majority of this work.

Add/Change #5655 (FileField's _save_FIELD_file method evaluates the directory once for creating the directory, then again for creating the file)




Change Properties
Action