inspectdb outputs invalid python variable when it encounters a dash

[redalastor@…]

When inspectdb encounters a field with a dash, it outputs it as a variable name which is invalid in python. For instance, when i ran it, I got the line:

buy-back_amount = models.FloatField(null=True, blank=True)

which I had to manually change to:

buy_back_amount = models.FloatField(null=True, blank=True, db_column="buy-back")

This was found in the SVN version of django with a mysql database.

[jbronn]

Replaces table name dashes with underscores.

[jbronn]

I attached a patch. Are there any other characters that are allowed in a SQL table name that aren't in a Python variable name?

[anonymous]

​http://dev.mysql.com/doc/refman/5.0/en/identifiers.html

Pretty much anything is allowed. It might even start with a digit.
What about python keywords?

import re, keyword
att_name = re.sub(r'[^a-z0-9_]', '_', row[0].lower())
if keyword.iskeyword(att_name):
    att_name += '_'
elif att_name[0].isdigit():
    att_name = '_' + att_name

And this won't be enough.

You would have to prevent clashes too to make it bulletproof (with other fields as well as Model methods and python __magic__).

I don't think that's worth it.

Stick to dash replacement if that's a common issue. And if you use perl code in your column names you will want to hack the output anyway.

[anonymous]

#6935 is the same problem with table names and spaces.

[Russell Keith-Magee]

(In [8404]) Fixed #7285: Improved inspectdb handling of dashes in table and field names. Thanks to redalastor@… for the report and Justin Bronn for the first part of a fix.

[Jacob]

Milestone 1.0 deleted